Fix execution permissions#75
Open
vmrfriz wants to merge 1 commit into
Open
Conversation
Checking and granting execution permissions for bash scripts. Tested only on Linux
Contributor
|
Thanks for your contribution! I'll check it out as soon as I can |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When starting with
tus:startand trying to upload a file, I got errors in the console saying that thepre-createfile wasn't executable. The solution was to manually executechmod +x vendor/oneofftech/laravel-tus-upload/hooks/*.The error when uploading looked like this:
Now, when starting
tus:start, it will be checked that thehooks/linux/*files have execution rights. If there are no rights, they will be given.Perhaps I was too hasty by not checking for the operating system and not testing on Windows. But I decided to leave it here for your comments or revision.