[VT Server]: Allow responses to messages which do not require a connection with a client #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… working set master separately Sometimes a VT client might request certain information from a VT server before it identifies itself as a working set master, and sometimes an external service tool might want to query some details from a VT, so, this allows more messages to be responded to by the VT server without a connection from a client.
|
Contributor
|
FYI I came across an implement which likely failed to load due to this: Unfortunately I have not managed to test with the updated stack as it was at the very end of the Agritechnica :( |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Sometimes a VT client might request certain information from a VT server before it identifies itself as a working set master, and sometimes an external service tool might want to query some details from a VT, so, this allows more messages to be responded to by the VT server without a connection from a client.
This will probably improve compatibility with some VT clients.
Specifically, we now allow the following messages from non-clients, or from clients earlier in the connection process.
The diff for this one is going to be large unfortunately... but basically all I did was move the messages into two different functions.
How has this been tested?
I have not yet had the chance to test it in our VT, but intend to test it shortly with #607