Add support for parsing Scaled Graphics objects from the IOP pool #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonmiklos
force-pushed
the
martonmiklos/add_support_for_scaled_graphics
branch
from
711dc02 to
66d0743
Compare
martonmiklos
changed the title
martonmiklos
force-pushed
the
martonmiklos/add_support_for_scaled_graphics
branch
from
98ca642 to
1d328a8
Compare
martonmiklos
force-pushed
the
martonmiklos/add_support_for_scaled_graphics
branch
from
1d328a8 to
d95945d
Compare
GwnDaan
requested changes
Dec 1, 2025
isobus/include/isobus/isobus/isobus_virtual_terminal_objects.hpp
Outdated
Show resolved
Hide resolved
martonmiklos
force-pushed
the
martonmiklos/add_support_for_scaled_graphics
branch
from
321fe40 to
32007a5
Compare
martonmiklos
force-pushed
the
martonmiklos/add_support_for_scaled_graphics
branch
from
32007a5 to
0e78ef6
Compare
ad3154
reviewed
Dec 9, 2025
|
GwnDaan
reviewed
Dec 30, 2025
Comment on lines
+2855
to
+2860
| if (iopLength >= sizeOfMacros) | ||
| { | ||
| for (std::uint_fast8_t i = 0; i < numberOfMacrosToFollow; i++) | ||
| { | ||
| // If the first byte is 255, then more bytes are used! 4.6.22.3 | ||
| if (iopData[0] == static_cast<std::uint8_t>(EventID::UseExtendedMacroReference)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds support for parsing object pools containing scaled graphics
Fixes # (issue)
How has this been tested?
NX9 VT6 test implement contains a scaled graphics object.