-
Notifications
You must be signed in to change notification settings - Fork 8
Added an encode routine for a CanId #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added a way to encode an extended CAN ID from its components. Also added an alias "BROADCAST" address which is the same as "GLOBAL"
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1c48543 |
Added tests for CanIdEncode
ded2794 to
f601540
Compare
Notgnoshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
offtopic: I like to use https://conventionalcomments.org/ for comments on PRs, because I'm terrible at conveying tone through comments.
When I leave a nitpick: comment, I intend to convey that it's not something major, and am comfortable merging the PR without addressing the comment.
Yeah, I know 😁 but these are super minor things in this case, I might as well make it as nice as possible now since they're quick, and it helps me learn rust-ways-of-doing-things (which as you all can probably see is something I still need to work on). |
This should make logging the error a little nicer since it provides more useful info.
f601540 to
1c48543
Compare
Added an encode routine for a CanId (Open-Agriculture#16)
It occurs to me that in my GitHub bio I say contributions are my own unless specified, so I should start saying when commits are on behalf of Raven.
So, this contribution is on behalf of Raven.