Add support for strikethrough text style #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonmiklos
force-pushed
the
dry_numbers
branch
3 times, most recently
from
dc924b7 to
48a6ab5
Compare
martonmiklos
force-pushed
the
dry_numbers
branch
2 times, most recently
from
2961c60 to
e05b69e
Compare
ad3154
previously requested changes
Mar 9, 2025
martonmiklos
commented
Mar 11, 2025
martonmiklos
force-pushed
the
dry_numbers
branch
from
271e266 to
fae43bf
Compare
Contributor
Author
|
Hi @ad3154 I think all of the issues were resolved this with except this: I have not found a better way to solve this with smart pointers. I tried to use enabled_shared_from_this but I have not been able to compile the code to store generic pointers in constructor. |
martonmiklos
force-pushed
the
dry_numbers
branch
2 times, most recently
from
eda301c to
6cbabe7
Compare
martonmiklos
force-pushed
the
dry_numbers
branch
3 times, most recently
from
8cbd1d7 to
0c92e58
Compare
GwnDaan
requested changes
Dec 1, 2025
GwnDaan
approved these changes
Dec 23, 2025
martonmiklos
force-pushed
the
dry_numbers
branch
from
1cefa5f to
100d319
Compare
martonmiklos
dismissed
ad3154’s stale review
Fixed by creating a vtObject() member
martonmiklos
added a commit
to martonmiklos/AgIsoVirtualTerminal
that referenced
this pull request
Dec 29, 2025
martonmiklos
added a commit
that referenced
this pull request
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support drawing strikethrough texts in Input/Output/String/Numbers.
Restructured the text drawing components, depends on Open-Agriculture/AgIsoStack-plus-plus#525