Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cbuild2cmake] Add API files to component target sources #237

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

brondani
Copy link
Collaborator

@brondani brondani commented Dec 4, 2024

Fixes

Changes

Checklist

  • 🤖 This change is covered by unit tests as required.
  • 🤹 All required manual testing has been performed.
  • 🛡️ Security impacts have been considered.
  • 📖 All documentation updates are complete.
  • 🧠 This change does not change third-party dependencies

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@brondani brondani force-pushed the add-api-files-to-component-sources branch from 86d928c to bed7c2c Compare December 4, 2024 13:24
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Test Results

  4 files  ±0   20 suites  ±0   2s ⏱️ -1s
 74 tests +1   74 ✅ +1  0 💤 ±0  0 ❌ ±0 
296 runs  +4  296 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 0c0946f. ± Comparison against base commit fef52a0.

♻️ This comment has been updated with latest results.

@brondani brondani marked this pull request as ready for review December 4, 2024 13:29
@brondani brondani requested a review from soumeh01 December 4, 2024 13:29
Co-authored-by: Sourabh Mehta <[email protected]>
Copy link

codeclimate bot commented Dec 4, 2024

Code Climate has analyzed commit 0c0946f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 85.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 88.0% (0.0% change).

View more on Code Climate.

@brondani brondani requested a review from soumeh01 December 4, 2024 14:29
@brondani brondani merged commit b1f3262 into main Dec 4, 2024
16 checks passed
@brondani brondani deleted the add-api-files-to-component-sources branch December 4, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants