Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[projmgr] Minimum component version handling (#276) #431

Merged

Conversation

grasci-arm
Copy link
Collaborator

  • [projmgr] Minimum component version handling

  • Code restructuring & addressed review comments

  • Handled HIGHER_OR_EQUAL case to MatchModeToString

* [projmgr] Minimum component version handling

* Code restructuring & addressed review comments

* Handled HIGHER_OR_EQUAL case to MatchModeToString
@soumeh01 soumeh01 requested a review from brondani August 17, 2022 15:10
@edriouk edriouk requested a review from spcaipers-arm August 18, 2022 15:19
@brondani brondani requested review from soumeh01 and removed request for spcaipers-arm August 23, 2022 08:29
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #431 (305e389) into main (1227b66) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   67.53%   67.59%   +0.06%     
==========================================
  Files          48       48              
  Lines        7624     7645      +21     
  Branches     1453     1453              
==========================================
+ Hits         5149     5168      +19     
- Misses       1693     1695       +2     
  Partials      782      782              
Flag Coverage Δ
buildmgr-cov 86.08% <ø> (+<0.01%) ⬆️
projmgr-cov 87.68% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tools/projmgr/src/ProjMgrWorker.cpp 89.01% <100.00%> (+0.03%) ⬆️
tools/buildmgr/cbuild/src/CbuildModel.cpp 82.17% <0.00%> (+0.05%) ⬆️

@soumeh01 soumeh01 requested a review from brondani August 23, 2022 09:59
@brondani brondani merged commit 00d5edb into Open-CMSIS-Pack:main Aug 23, 2022
@brondani brondani deleted the outbound/MinComponentVersion branch August 23, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants