Remove unneeded changes.

openeogeotrellis/configparams.py

@@ -45,7 +45,7 @@ def __init__(self, env=os.environ):
         self.layer_catalog_metadata_files = env.get("OPENEO_CATALOG_FILES", "layercatalog.json").split(",")
 
         # TODO #283 using this "is_kube_deploy" switch is an anti-pattern (induces hard to maintain code and make unit testing difficult)
-        self._is_kube_deploy = env.get("KUBE", False)
+        self.is_kube_deploy = env.get("KUBE", False)
         self.pod_namespace = env.get("POD_NAMESPACE", "spark-jobs")
         self.concurrent_pod_limit = int(env.get("CONCURRENT_POD_LIMIT", 0))  # 0 means no limit.
 
@@ -70,10 +70,6 @@ def _as_boolean(envar_value: Optional[str]) -> bool:
         # TODO: use `openeo_driver.utils.smart_bool` instead?
         return envar_value is not None and envar_value.lower() == "true"
 
-    @property
-    def is_kube_deploy(self):
-        return self._is_kube_deploy
-
     @property
     def use_object_storage(self):
         """Whether or not to get the result files / assets from object storage.

openeogeotrellis/utils.py

@@ -442,8 +442,9 @@ def single_value(xs):
 def add_permissions(path: Path, mode: int):
     # TODO: accept PathLike etc as well
     # TODO: maybe umask is a better/cleaner option
-    if str(path).lower().startswith("s3:/"):
-        return
+    # TODO: Don't change permissions on s3 urls?
+    # if str(path).lower().startswith("s3:/"):
+    #     return
     if path.exists():
         current_permission_bits = os.stat(path).st_mode
         os.chmod(path, current_permission_bits | mode)