Validate upload content before persisting to /uploads#2
Open
ORDL-AMF wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/uploadswithout content validation./uploadsmount cannot serve HTML/SVG/JS from user uploads.Description
_validated_image_suffix(content: bytes)which attempts to parse the bytes with Pillow and maps trusted raster formats to safe extensions (.jpg,.png,.webp,.gif,.bmp,.tiff)._persist_uploaded_assetto call_validated_image_suffixand only write files when the content is a supported image; otherwise it returnsNoneand logs a warning, preserving existing behavior of returningasset_urlwhen persisted.BytesIO,PIL.Image,UnidentifiedImageError) and removed the prior filename-suffix reliance.Testing
python -m py_compile aether-system/backend/api/routes.pyand it succeeded to validate syntax._validated_image_suffixbut the environment lackedfastapiwhich caused import failure (ModuleNotFoundError: No module named 'fastapi'), so dynamic execution tests were not completed.Codex Task