Skip to content

Conversation

@Rapha-L
Copy link

@Rapha-L Rapha-L commented Jan 2, 2025

This branch adds documentation within the 'Shared Tools and Example Workflows" tab about extracting physiological parameters from a population within the PKSim database and creating time-varying parameters in Mobi. The exemplary workflow is illustrated with the parameter 'breasts volume' during postpartum.

@Yuri05
Copy link
Member

Yuri05 commented Jan 3, 2025

I am not sure, why the Postpartum population was selected for the example code.
Currently it is not part of the official PK-Sim release, so that applying the example code returns just empty tables.
E.g. the Pregnant population might be a better choice

@Yuri05 Yuri05 requested a review from PavelBal January 3, 2025 16:27
Copy link
Member

@PavelBal PavelBal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yuri05 I think this is good to be merged.

@Yuri05
Copy link
Member

Yuri05 commented Jan 28, 2025

@Rapha-L Can you please add the words below to .github/workflows/wordlist.txt ?
This will remove the spellchecker warnings.

addWorksheet
conn
ContainerName
createWorkbook
dbConnect
dbGetQuery
df
distributedParam
param
PARAM
PKSimDB
PKsimDB
readWorkbook
saveWorkbook
wb
writeData

@Yuri05 Yuri05 requested a review from Copilot April 8, 2025 13:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • .github/workflows/wordlist.txt: Language not supported
Comments suppressed due to low confidence (2)

part-5/db_extraction-physiological-parameters.md:113

  • [nitpick] There is an inconsistency in the parameter naming format: 'Postpartum Age' uses a space while similar references elsewhere use 'Postpartum_Age'. Consider using a consistent naming convention to avoid confusion.
    -   Add parameter 'Organism|Postpartum Age'

part-5/db_extraction-physiological-parameters.md:155

  • [nitpick] The parameter name 'Postpartum_age' here is inconsistent with the 'Postpartum Age' mentioned above. Please standardize the naming to improve clarity.
    -   Path to X-Argument object should point to 'Organism|Postpartum_age'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants