-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[csharp] Duration format property support #20519
base: master
Are you sure you want to change the base?
Conversation
...penapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractCSharpCodegen.java
Show resolved
Hide resolved
@devhl-labs can you approve? |
I cant maybe @wing328 |
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
1758ee4
to
012cb5f
Compare
012cb5f
to
e4a6153
Compare
Thanks. I think I have now fixed it and rebased all my commits down to one + the sync to merge it from master |
@wing328 is this ready to go in now? |
some builds failed. can you please take a look when you've time? |
@devhl-labs can you help check the generichost failure? I have updated the JsonConverter.mustache, but not sure how to get it to now generate the updates needed to emit as |
Looks like it will need a JsonConverter<TimeSpan> class. Feel free to exclude generichost from this change for now if you like. |
Add support for duration property to be applied to
format
.Currently only configured/built for c#. Need to determine path forward to implement further.
@wing328
Related to #14305
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)