Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp] Duration format property support #20519

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

balassit
Copy link
Contributor

@balassit balassit commented Jan 22, 2025

Add support for duration property to be applied to format.
Currently only configured/built for c#. Need to determine path forward to implement further.

@wing328

Related to #14305

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@balassit balassit changed the title [WIP][csharp] Duration format property support [csharp] Duration format property support Jan 22, 2025
@balassit balassit marked this pull request as ready for review January 22, 2025 05:59
@balassit
Copy link
Contributor Author

balassit commented Feb 4, 2025

@devhl-labs can you approve?

@devhl-labs
Copy link
Contributor

I cant maybe @wing328

@wing328
Copy link
Member

wing328 commented Feb 5, 2025

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@balassit balassit force-pushed the balassit/timespan branch 2 times, most recently from 1758ee4 to 012cb5f Compare February 6, 2025 03:06
@balassit
Copy link
Contributor Author

balassit commented Feb 6, 2025

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

Thanks. I think I have now fixed it and rebased all my commits down to one + the sync to merge it from master

@balassit
Copy link
Contributor Author

balassit commented Feb 7, 2025

@wing328 is this ready to go in now?

@wing328
Copy link
Member

wing328 commented Feb 9, 2025

some builds failed. can you please take a look when you've time?

@balassit
Copy link
Contributor Author

@devhl-labs can you help check the generichost failure? I have updated the JsonConverter.mustache, but not sure how to get it to now generate the updates needed to emit as JsonSerializer.Deserialize<Timespan>

@devhl-labs
Copy link
Contributor

devhl-labs commented Feb 14, 2025

Looks like it will need a JsonConverter<TimeSpan> class. Feel free to exclude generichost from this change for now if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants