-
-
Notifications
You must be signed in to change notification settings - Fork 93
detectable.json: minor fixes #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
the detectable json is not manually written it comes from discords api |
Then answer me. If they have shared database, why Discord can detect then I play Half-life or dota or CS or smth and arRPC is not?. And why arRPC can detect them to after my fix? |
EXACTLY. I have to edit the I don't think discord uses the same file. |
If you take a look at This seems to only have the following games detected on Linux:
I checked the v10 version of this API and it was the same. So @Sk7Str1p3, I'm really not sure how discord can be detecting games like half-life, dota etc on Linux considering the official detectable json from Discord doesn't include them. I tried hl1, hl2, and cs2, none of them were detected by either arRPC+vesktop or official discord. And this is what I would expect since these are missing in the detectable json - for example, Dota 2 only has detection on windows and OSX. Given the above, I don't feel like this PR is the best idea in its current state. Maybe we need to decide on the approach to take:
I'd be more in favour of option 2 because I doubt discord is going to improve linux game detection any time soon. |
I am in favor of option 2 too. Discord's proprietary RTC game detection on Linux is just awful, so most Linux users use arrpc instead. |
Option 2 would be preferable, but that is a lot of work to maintain. I'm currently improving my javascript knowledge to learn how to perform on-import database fixes for a few games, as the alternative way to match against them on Linux involves very cpu-intensive checks in the hot path. You can track my progress in #143 if you're interested in trying a version that includes more detected games. |
format json for better performance in editors and human-readability; add few steam games for detection on linix (wip)