Skip to content

detectable.json: minor fixes #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Sk7Str1p3
Copy link

format json for better performance in editors and human-readability; add few steam games for detection on linix (wip)

@Covkie
Copy link
Contributor

Covkie commented Feb 5, 2025

the detectable json is not manually written it comes from discords api

@Sk7Str1p3
Copy link
Author

Sk7Str1p3 commented Feb 5, 2025

Then answer me. If they have shared database, why Discord can detect then I play Half-life or dota or CS or smth and arRPC is not?. And why arRPC can detect them to after my fix?

@Abdorithm
Copy link

Then answer me. If they have shared database, why Discord can detect then I play Half-life or dota or CS or smth and arRPC is not?. And why arRPC can detect them to after my fix?

EXACTLY. I have to edit the detectable.json manually to detect some native linux games, which are detected fine with discord's closed RPC. The linux executable for native linux games like war thunder and dota 2 are not present in detectable.json.

I don't think discord uses the same file.

@eiglow
Copy link

eiglow commented Mar 23, 2025

If you take a look at update_db.js, you'll see it grabs this json from Discord's API at https://discord.com/api/v9/applications/detectable.

This seems to only have the following games detected on Linux:

1 Move or Die
11 Counter-Strike: Global Offensive
31 Terraria
1171 Throne of Lies
1747 VA-11 HALL-A

I checked the v10 version of this API and it was the same. So @Sk7Str1p3, I'm really not sure how discord can be detecting games like half-life, dota etc on Linux considering the official detectable json from Discord doesn't include them. I tried hl1, hl2, and cs2, none of them were detected by either arRPC+vesktop or official discord. And this is what I would expect since these are missing in the detectable json - for example, Dota 2 only has detection on windows and OSX.

Given the above, I don't feel like this PR is the best idea in its current state. Maybe we need to decide on the approach to take:

  1. Only use discord's official detectable db. We will continue to have crappy game detection on Linux. This is the current state. We won't have to maintain our own db though.
  2. Maintain our own "fork" of the discord detectable db. This would need changes to update_db.js in order for this to make sense. But then we can have community contributions of additional linux detection etc.

I'd be more in favour of option 2 because I doubt discord is going to improve linux game detection any time soon.

@Abdorithm
Copy link

Given the above, I don't feel like this PR is the best idea in its current state. Maybe we need to decide on the approach to take:

  1. Only use discord's official detectable db. We will continue to have crappy game detection on Linux. This is the current state. We won't have to maintain our own db though.
  2. Maintain our own "fork" of the discord detectable db. This would need changes to update_db.js in order for this to make sense. But then we can have community contributions of additional linux detection etc.

I'd be more in favour of option 2 because I doubt discord is going to improve linux game detection any time soon.

I am in favor of option 2 too. Discord's proprietary RTC game detection on Linux is just awful, so most Linux users use arrpc instead.

@XenHat
Copy link

XenHat commented Apr 27, 2025

Option 2 would be preferable, but that is a lot of work to maintain. I'm currently improving my javascript knowledge to learn how to perform on-import database fixes for a few games, as the alternative way to match against them on Linux involves very cpu-intensive checks in the hot path. You can track my progress in #143 if you're interested in trying a version that includes more detected games.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants