[CI] Re-enable backward compatibility check #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Re-enables the backward compatibility validation workflow by removing a TODO comment that was preventing the check from running. This restores automated validation of API compatibility changes in the CI pipeline.
- Removes temporary TODO comment that disabled the backward compatibility check
- Restores automated backward compatibility validation in the CI workflow
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Revert "[CI] Disable backward compatibility check" This reverts commit ab9ad28. The check was disabled on the initial commit, since there was no history to diff against, so the check failed. Signed-off-by: David Feltell <[email protected]>
feltech
force-pushed
the
work/reenableBackwardCompatCheck
branch
from
f5b8b27 to
b79f3dc
Compare
Member
Author
|
Fails since the 3rd party action does not install our dependencies, moving to draft whilst looking into it. |
On re-enabling the backward compatibility check that came with the ComfyUI cookiecutter project, it failed due to missing dependencies (specifically pytorch). So install dependencies before running the action. Choose dependencies from the PR rather than main, in case they are different, in the spirit of testing backward compatibility. Signed-off-by: David Feltell <[email protected]>
feltech
force-pushed
the
work/reenableBackwardCompatCheck
branch
from
7332228 to
c4b38c5
Compare
We use `main` rather than `master`, so there's no need to check for PRs against `master`. Signed-off-by: David Feltell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "[CI] Disable backward compatibility check"
This reverts commit ab9ad28.
The check was disabled on the initial commit, since there was no history to diff against, so the check failed.
Add dependencies before executing the 3rd party action, otherwise it fails to import our nodes.