Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ganglion v3 firmware detection on MacOS #1194

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

philippitts
Copy link
Member

@philippitts philippitts commented Sep 22, 2023

Fixes #1191

Tests:

  • Windows 11 BLED112 dongle
  • Windows 11 Native Bluetooth
  • MacOS 10.15.7 BLED112
  • MacOS 10.15.7 Native
  • MacOS 13 BLED112
  • MacOS 13 Native

@retiutut
Copy link
Member

Screen Shot 2023-09-24 at 6 47 06 PM

There is cyclical noise using Native Bluetooth and Ganglion v3.0.1 firmware on both 10.15.7 and 13.5.2. Details of what's happening can be seen in the Console log in the screenshot.

Copy link
Member

@retiutut retiutut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cyclical noise using native bluetooth. Probably caused by library mismatch. Possibly fixed by update to BrainFlow 5.10.1.

@retiutut
Copy link
Member

retiutut commented Sep 26, 2023

Screenshot 2023-09-26 102516

Invalid memory access using Native Bluetooth on a Windows 11 machine with built-in bluetooth. Happens occasionally.

It happens just after the bluetooth connects to the device to check properties, since I see it's connected via the light.

@DashBarkHuss
Copy link

Tested this on Mac M1 Sonoma 14.6.1

see forum comment

@wjcroft
Copy link

wjcroft commented Oct 2, 2024

This PR fixes V3 'detection', as it is being logged correctly when PR is tested by @DashBarkHuss . HOWEVER, even though the V3 is detected, the V3 native Ganglion packet parsing code (by Phil) is not being engaged, as evidenced by the careful video demo that Dash recorded on the Forum thread. Sounds like an easy add on fix to this PR. @philippitts

https://openbci.com/forum/index.php?p=/discussion/3913/using-native-bluetooth-causes-1-second-pulses-on-ganglion#latest

@philippitts
Copy link
Member Author

Referencing OpenBCI/OpenBCI_Ganglion_Library#27. It seems like the Device Name characteristic of the Generic Access BLE service defaults to "Simblee". This may be what the problematic instances of macOS are reading with native BLE, but it needs to be tested.

If this fixes the problem of with device name discovery on macOS, we can revert the changes in brainflow-dev/brainflow#675.

@DashBarkHuss
Copy link

DashBarkHuss commented Feb 19, 2025

hey did this fix the native Bluetooth issue on mac?

@retiutut retiutut self-requested a review April 2, 2025 23:20
Copy link
Member

@retiutut retiutut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to get this across the finish line.

@retiutut retiutut force-pushed the 1191-ganglion-v3-firmware-not-detected-on-some-macos-versions branch from 12fc347 to 05da93e Compare April 2, 2025 23:27
@retiutut
Copy link
Member

retiutut commented Apr 2, 2025

Merge conflicts resolved with development. Please git reset origin/1191-ganglion-v3-firmware-not-detected-on-some-macos-versions --hard before starting work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants