-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ganglion v3 firmware detection on MacOS #1194
base: development
Are you sure you want to change the base?
Fix Ganglion v3 firmware detection on MacOS #1194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cyclical noise using native bluetooth. Probably caused by library mismatch. Possibly fixed by update to BrainFlow 5.10.1.
Tested this on Mac M1 Sonoma 14.6.1 |
This PR fixes V3 'detection', as it is being logged correctly when PR is tested by @DashBarkHuss . HOWEVER, even though the V3 is detected, the V3 native Ganglion packet parsing code (by Phil) is not being engaged, as evidenced by the careful video demo that Dash recorded on the Forum thread. Sounds like an easy add on fix to this PR. @philippitts |
Referencing OpenBCI/OpenBCI_Ganglion_Library#27. It seems like the Device Name characteristic of the Generic Access BLE service defaults to "Simblee". This may be what the problematic instances of macOS are reading with native BLE, but it needs to be tested. If this fixes the problem of with device name discovery on macOS, we can revert the changes in brainflow-dev/brainflow#675. |
hey did this fix the native Bluetooth issue on mac? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to get this across the finish line.
12fc347
to
05da93e
Compare
Merge conflicts resolved with |
Fixes #1191
Tests: