Skip to content

feat: add gallery endpoint #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from
Draft

feat: add gallery endpoint #1297

wants to merge 13 commits into from

Conversation

clintonlunn
Copy link
Collaborator

@clintonlunn clintonlunn commented Mar 1, 2025 •
edited
Loading

name: Pull request
about: Create a pull request
title: ''
labels: ''
assignees: ''

What type of PR is this?(check all applicable)

  • refactor
  • feature
  • bug fix
  • documentation
  • optimization
  • other

Description

Related Issues

Issue #

What this PR achieves

Screenshots, recordings

Notes

@clintonlunn clintonlunn linked an issue Mar 1, 2025 that may be closed by this pull request
rebuild photo gallery component to its own page using ssr #1212
Open
@clintonlunn
Copy link
Collaborator Author

Added a temporary button to each climb and area page that routes to an ssr gallery
image

@clintonlunn
Copy link
Collaborator Author

still a very much WIP, but some preliminary screenshots

I used the nextjs concepts of parallel routes and intercepting routes that allows us to have a modal as well as a fallback component that loads in the shared url. this was a new concept for me so i may be doing things in not the best or most correct way. any feedback appreciated.

image
image

Fallback
image

@clintonlunn
Copy link
Collaborator Author

@vnugent @mikeschen maybe i can get some preliminary feedback on this. I think this would have the potential to satisfy both #1212 and #1214. It's using parallel and intercepting routes that lets us have both a client side rendered modal as well as an ssr fallback component. Obviously I kinda copied the usergallery component. My eventual goal is to refactor the user gallery page to use this more general version of the <SlideViewer />.

mikeschen
mikeschen reviewed May 21, 2025
View reviewed changes
Copy link
Contributor

@mikeschen mikeschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I'm totally fine with this and seems to be an improvement. Let me know if you need any help.
Just a request to have another name besides "p" for the folder.

@mikeschen mikeschen added the enhancement Improving existing functionality label May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeschen mikeschen mikeschen left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement Improving existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rebuild photo gallery component to its own page using ssr
2 participants
@clintonlunn @mikeschen