Uniprot #470
Merged
Uniprot #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there something you still need help with? |
kjappelbaum
reviewed
Nov 1, 2023
data/tabular/uniprot/transform.py
Outdated
Comment on lines
5
to
7
| def load_dataset() -> pd.DataFrame: | ||
| uniprot = pd.read_csv("reactions_sentences.csv") | ||
| uniprot.to_csv("data_clean.csv", index=False) |
There was a problem hiding this comment.
this would still require update to something we can download
kjappelbaum
reviewed
Nov 1, 2023
data/tabular/uniprot/meta.yaml
Outdated
Comment on lines
6
to
14
| - id: sentences | ||
| description: sentences describing the catalytic activity of a protein | ||
| names: | ||
| - noun: catalytic activity | ||
| - id: reactions | ||
| description: biochemical reactions catalyzed by a protein | ||
| names: | ||
| - noun: chemical reactions | ||
| - noun: biochemical reactions |
There was a problem hiding this comment.
can you also get smth about the binding sites and the function description?
|
thanks for giving this a look! |
MicPie
reviewed
Nov 7, 2023
MicPie
reviewed
Nov 7, 2023
Co-authored-by: Michael Pieler <[email protected]>
MicPie
reviewed
Nov 9, 2023
MicPie
reviewed
Nov 9, 2023
MicPie
reviewed
Nov 9, 2023
MicPie
reviewed
Nov 9, 2023
MicPie
requested changes
Nov 9, 2023
Co-authored-by: Michael Pieler <[email protected]>
Co-authored-by: Michael Pieler <[email protected]>
Co-authored-by: Michael Pieler <[email protected]>
Co-authored-by: Michael Pieler <[email protected]>
Co-authored-by: Kevin M Jablonka <[email protected]>
Closed
MicPie
approved these changes
Nov 18, 2023
|
ok, I'll try to fix the CI and try sampling once I'm back from groceries |
|
Thanks for the updates, @AdrianM0! Really appreciate that you squeezed this in at the last minute! |
|
There is a bit of leakage in some of the descriptions |
kjappelbaum
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.