-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #236 #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mb2055
previously approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 All good (once the CI is done)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #236 by restricting the loop over the
start_indexes
vector to the number of molecules in the system.Also closes #238 by fixing the calculation of
delta^2
used in the Coulomb term of the nonbonded expressions.Also closes #239 by excluding to/from ghost interactions from the
ghost_14ff
.Also closes #230 by adding a crude timeout to the OpenMM minimiser. This just checks to see if a maximum number of seconds has been exceeded in both the inner and outer loops of the code. This obviously doesn't check the timing within the internal line search algorithm itself. The main point of this is allow the user a single lever to control the max time (roughly) before the minimiser exits, rather than needing to adjust the number of iterations, ratchets, etc. (And even then, those might still lead to a hang.)
Also closes #241 by re-computing the energy after performing the final constraint projection in order to get the correct delta energy.
Also closes #242 by clearing the internal OpenMM state of the dynamics object when performing a minimisation.
devel
into this branch before issuing this pull request (e.g. by runninggit pull origin devel
): [y]