Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2024.4.0 #282

Merged
merged 124 commits into from
Feb 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
124 commits
Select commit Hold shift + click to select a range
05e38a9
Initial update for angle restraints
akalpokas Jul 10, 2024
12af94a
Intial addition of alchemical dihedral restraints and angle restraint…
akalpokas Jul 10, 2024
8809ac5
Update wrappers for angle and dihedral restraints classes
akalpokas Jul 16, 2024
386912d
Added intial python code for implementing alchemical dihedral restraints
akalpokas Jul 16, 2024
69a7ee2
Added prototype code for adding alchemical dihedral restraints to Ope…
akalpokas Jul 16, 2024
c29c4eb
Fix conversion of dihedral restraints to OpenMM system
akalpokas Jul 16, 2024
4a0726d
Added full end-to-end alchemical dihedral restraints implementation -…
akalpokas Jul 17, 2024
9eeb824
Added full end-to-end alchemical angle restraints implementation, and…
akalpokas Jul 19, 2024
a500bc9
Add the missing corelib files for angle restraints
akalpokas Jul 19, 2024
55eb13e
Merge branch 'OpenBioSim:devel' into feature_alchemical_restraints_contd
akalpokas Jul 20, 2024
ff207f5
Update to the 2024.4.0.dev release. [ci skip]
lohedges Oct 23, 2024
bee9b06
Fix note formatting. [ci skip]
lohedges Oct 23, 2024
4fcc147
Fix tutorial section formatting. [ci skip]
lohedges Oct 23, 2024
926f082
Fix instantiation of QByteArray and counting of bytes. [closes #249]
lohedges Oct 28, 2024
a2370a4
Increase wait before terminating QThreads. [closes #251] [ci skip]
lohedges Oct 29, 2024
808dad7
Update CHANGELOG. [ci skip]
lohedges Oct 29, 2024
9d9f51b
Give thread a chance to finish and inform user. [ci skip]
lohedges Oct 29, 2024
146632e
Merge pull request #250 from OpenBioSim/fix_249
lohedges Oct 29, 2024
a5d704f
Expose missing timeout kwarg in dynamics.minimise(). [closes #253]
lohedges Oct 29, 2024
32f27a4
Add include_constrained_energies kwarg to map. [ref #255]
lohedges Oct 29, 2024
53182c3
Add consistent minimisation settings. [closes #255]
lohedges Oct 29, 2024
b7cee4b
Update CHANGELOG.
lohedges Oct 29, 2024
97d7f2f
Merge pull request #254 from OpenBioSim/fix_253
lohedges Oct 30, 2024
be8aa3a
Make Boresch restraints correction consistent with F=2kx
Nov 1, 2024
63e76ea
Update docs to make clear that F = 2kx for restraints
Nov 1, 2024
add86c0
Don't always save frames and energies after dynamics.run() [ref #256]
lohedges Oct 30, 2024
175ecf4
Simplify test logic.
lohedges Nov 8, 2024
46b5d3f
Fix thread safety issue in OpenMM minimiser. [closes #259]
lohedges Nov 8, 2024
627926e
Remove redundant include.
lohedges Nov 8, 2024
a291ea4
Update CHANGELOG.
lohedges Nov 11, 2024
a1c1277
Improve handling of OpenMM NaN errors at runtime.
lohedges Nov 11, 2024
597d8c3
Add support for REST2.
lohedges Nov 21, 2024
21af746
Allow per-lambda REST2 scaling factors.
lohedges Nov 25, 2024
9a3d8a5
Fix update of PeriodicTorsionForce parameters.
lohedges Nov 26, 2024
67947e6
Fix calculation of molecule atom offset.
lohedges Nov 26, 2024
e61b39d
Add missing scale factor in exception.
lohedges Nov 28, 2024
1bc4e46
Workaround for device change during minimisation. [ref #262]
lohedges Nov 29, 2024
3e866de
Add minimisation step to QM/MM tutorials. [ref #262]
lohedges Nov 29, 2024
c064358
Fix QM-to-MM non-equilibrium work. [ref #262]
lohedges Nov 29, 2024
217906a
Update CHANGELOG. [ci skip]
lohedges Dec 2, 2024
9c3aa12
Fix setting of RDKit bond orders. [ref #261]
lohedges Dec 2, 2024
41d1f07
Set bond stereo information. [ref #261]
lohedges Dec 2, 2024
b4a1c3b
Allow implicit hydrogens. [ref #261]
lohedges Dec 2, 2024
3720ab9
Assign sterochemistry from 3D coordinates. [ref #261] [ci skip]
lohedges Dec 2, 2024
88646ff
XFail test since SDF stereochemistry is now preserved. [ref #261]
lohedges Dec 2, 2024
918690d
Update CHANGELOG.
lohedges Dec 2, 2024
d48d138
Merge remote-tracking branch 'fjclark/bugfix-boresch-correction' into…
lohedges Dec 3, 2024
1e253b1
Fix thread safety issue in OpenMM minimiser. [closes #259]
lohedges Dec 3, 2024
4fdbf8a
Update rest2_scale factor attribute when it changes.
lohedges Dec 3, 2024
bc28788
Apply REST2 scale factor on instantiation.
lohedges Dec 3, 2024
6cfa5c3
Udpate lambda if REST2 scale factor changes.
lohedges Dec 3, 2024
0682d00
Apply REST2 scaling factor in SOMMContext constructor.
lohedges Dec 3, 2024
dec3ce8
Merge pull request #263 from OpenBioSim/fix_262
lohedges Dec 3, 2024
d1df185
Add missing Sire-EMLE documentation updates. [ci skip]
lohedges Dec 4, 2024
2e1ceb7
Add REST2 related attributes to copy constructor.
lohedges Dec 4, 2024
b985273
Merge branch 'devel' into feature_repex
lohedges Dec 4, 2024
6f2421d
Make sure REST2 scale factor is reset after computing energies.
lohedges Dec 4, 2024
913473f
Only update lambda and REST2 scale factors if needed.
lohedges Dec 4, 2024
060325a
Fix update of triclinic box vectors. [closes #265]
lohedges Dec 9, 2024
c252141
Update CHANGELOG.
lohedges Dec 9, 2024
e33ceec
Merge pull request #266 from OpenBioSim/fix_265
lohedges Dec 13, 2024
b960b29
Merge branch 'devel' into feature_repex
lohedges Dec 13, 2024
3696e31
Try reducing the number of cores used to compile wrappers on Windows.
lohedges Jan 6, 2025
a1642de
Revert change to number of cores used to compile wrappers. [ci skip]
lohedges Jan 6, 2025
0aeb6ca
Remove redundant optimised callback interface. [closes #269]
lohedges Jan 7, 2025
ecfef72
Merge pull request #271 from OpenBioSim/fix_269
lohedges Jan 7, 2025
6705e14
Handle cis/trans double bond stereo value in SDF files. [closes #270]
lohedges Jan 7, 2025
c5404cf
Sync with upstream devel branch
akalpokas Jan 10, 2025
691223a
Updated restraints tutorial to include angle and dihedral restraints,…
akalpokas Jan 10, 2025
ab2188d
Add basic unit tests for the new restraints
akalpokas Jan 10, 2025
35725d8
Updated changelog and contributor pages for the PR
akalpokas Jan 10, 2025
6a41c93
Add test for OpenMM REST2 modifications.
lohedges Jan 13, 2025
f02fcd1
Update test to cover partial REST2 selection.
lohedges Jan 13, 2025
2b4ab01
Typo.
lohedges Jan 13, 2025
d84b7b3
Update alchemical dynamics docs with REST2 information.
lohedges Jan 14, 2025
cac3e05
Use reference platform for test.
lohedges Jan 14, 2025
9df2ddf
Only need rest2_scale_factors when lambda_windows is not None.
lohedges Jan 14, 2025
85b68f4
Only loop until runtime is exceeded, not save interval.
lohedges Jan 14, 2025
70b5c68
Add test for dynamics save frequency modifications. [ref #256]
lohedges Jan 14, 2025
4c188f9
Merge branch 'devel' into feature_repex
lohedges Jan 14, 2025
1a1b5e8
Attempt to fix threading exception handling issue.
lohedges Jan 14, 2025
36747f0
No need for inner while loop.
lohedges Jan 14, 2025
420f016
Remove early exit in set_lambda method.
lohedges Jan 14, 2025
65fbd03
Removed whitespace that was added and tidied up python restraints fil…
akalpokas Jan 14, 2025
945674c
Added force names to custom OpenMM angle and torsion forces
akalpokas Jan 14, 2025
37648f1
Restore thread before throwing any exceptions.
lohedges Jan 14, 2025
67f52c8
Add test for non-perturbable REST2 atoms and fix partial selections.
lohedges Jan 15, 2025
3eff41b
Fix REST2 selection handling.
lohedges Jan 15, 2025
e18be08
Update CHANGELOG.
lohedges Jan 15, 2025
ce73658
Fix adjustment of block size based on sampling frequency.
lohedges Jan 15, 2025
02b4ee3
Find force by name to avoid issues if ordering changes. [ci skip]
lohedges Jan 16, 2025
5ca5ced
Use .num_frames() method for simplicity. [ci skip]
lohedges Jan 16, 2025
5b52f86
Add option to always save a frame when .run() exits.
lohedges Jan 16, 2025
b919d6e
Add option to always save the energy when .run() exits.
lohedges Jan 16, 2025
964a670
Null the SystemTrajectory pointer when deleting all frames. [ci skip]
lohedges Jan 17, 2025
50dc2de
Fix handling of positive formal charge when writing SDF. [closes #274]
lohedges Jan 17, 2025
3b2f984
Update CHANGELOG. [ci skip]
lohedges Jan 17, 2025
1ca8839
Merge branch 'fix_270' into feature_repex [ci skip]
lohedges Jan 20, 2025
e4c4b52
Change hyperthetical->hypothetical
mb2055 Jan 20, 2025
ad7fa7b
Update images to in line with actual outputs and remove redundant note
mb2055 Jan 20, 2025
1a38422
Subplots in code snippets in line with new plots [ci skip]
mb2055 Jan 20, 2025
d5bf9b5
Reduce image sizes [ci skip]
mb2055 Jan 21, 2025
050d5e8
Merge remote-tracking branch 'origin/Alchem_dynamics_docs_change' int…
lohedges Jan 21, 2025
5bdafc8
Update CHANGELOG. [ci skip]
lohedges Jan 21, 2025
0e56c8e
Removed redundant comments for restraints code [ci skip]
akalpokas Jan 21, 2025
65eab80
Merge remote-tracking branch 'akalpokas/feature_alchemical_restraints…
lohedges Jan 21, 2025
2cd0d82
Merge pull request #273 from OpenBioSim/feature_repex
lohedges Jan 21, 2025
5dbc955
Exclude alchemical ions from the REST2 region.
lohedges Jan 24, 2025
af71419
Allow user to compute energies over subset of lambda windows. [ci skip]
lohedges Jan 27, 2025
ff8b4fc
Compute num_lambda_windows when lambda_windows is not None. [ci skip]
lohedges Jan 29, 2025
790f7d2
Clarify that all windows are used when None. [ci skip]
lohedges Jan 29, 2025
961e15e
Merge pull request #277 from OpenBioSim/fix_rest2_alchemical_ions
lohedges Jan 29, 2025
fc30fb2
Fix hasForceSpecificEquation
Jan 29, 2025
5c2dacf
Update changelog [ci skip]
Jan 29, 2025
3cbe190
Merge branch 'devel' into bugfix-force-specific-equation [ci skip]
Jan 30, 2025
b3a566b
Merge pull request #280 from fjclark/bugfix-force-specific-equation
lohedges Jan 30, 2025
b29e168
Add support for OpenMM MonteCarloMembraneBarostat.
lohedges Feb 3, 2025
a5278e9
Merge pull request #281 from OpenBioSim/feature_membrane_barostat
lohedges Feb 4, 2025
68b2ad8
Merge branch 'main' into release_2024.4.0
lohedges Feb 4, 2025
8e8582b
Update CHANGELOG for the 2024.4.0 release.
lohedges Feb 4, 2025
4199df4
Bump version.
lohedges Feb 4, 2025
77a4447
Handle zero and NoneType for dynamics save frequencies. [closes #283]
lohedges Feb 4, 2025
9de605e
Merge pull request #284 from OpenBioSim/fix_283
lohedges Feb 4, 2025
cb9f92d
Merge branch 'devel' into release_2024.4.0
lohedges Feb 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions corelib/src/libs/SireCAS/lambdaschedule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1032,8 +1032,12 @@ bool LambdaSchedule::hasForceSpecificEquation(const QString &stage,

if (force == "*")
return false;
else
return this->stage_equations[idx].contains(_get_lever_name(force, lever));

// If there is a default equation for this force, always return true
if (this->stage_equations[idx].contains(_get_lever_name(force, "*")))
return true;

return this->stage_equations[idx].contains(_get_lever_name(force, lever));
}

SireCAS::Expression LambdaSchedule::_getEquation(int stage,
Expand Down
7 changes: 7 additions & 0 deletions corelib/src/libs/SireIO/sdf.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -959,6 +959,13 @@ SDFMolecule parseMolecule(const Molecule &molecule, QStringList &errors, const P
sdfmol.addProperty("CHG", i + 1, QString::number(charge));
charge = 0;
}
else if (charge > 0)
{
if (charge < 4)
{
charge = 4 - charge;
}
}
else if (charge < 0)
{
switch (charge)
Expand Down
8 changes: 4 additions & 4 deletions corelib/src/libs/SireMM/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ include_directories(${TBB_INCLUDE_DIR})
# Define the headers in SireMM
set ( SIREMM_HEADERS
amberparams.h
anglerestraint.h
anglerestraints.h
angle.h
atomfunctions.h
atomljs.h
Expand All @@ -43,7 +43,7 @@ set ( SIREMM_HEADERS
cljworkspace.h
coulombpotential.h
dihedral.h
dihedralrestraint.h
dihedralrestraints.h
distancerestraint.h
errors.h
excludedpairs.h
Expand Down Expand Up @@ -110,7 +110,7 @@ set ( SIREMM_SOURCES

amberparams.cpp
angle.cpp
anglerestraint.cpp
anglerestraints.cpp
atomfunctions.cpp
atomljs.cpp
bond.cpp
Expand All @@ -135,7 +135,7 @@ set ( SIREMM_SOURCES
cljworkspace.cpp
coulombpotential.cpp
dihedral.cpp
dihedralrestraint.cpp
dihedralrestraints.cpp
distancerestraint.cpp
errors.cpp
excludedpairs.cpp
Expand Down
Loading
Loading