-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #304 and #305 #307
Open
lohedges
wants to merge
5
commits into
devel
Choose a base branch
from
fix_304_305
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like
|
Presumably there are some breaking changes with version 0.7, although that did appear to come out over 3 months ago 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #304 by adding support for negative residue numbers. The existing tests appear to be unaffected by this change, but we might need to handle parser-specific issues as they arise. While I have added the ability to load and set negative residue numbers for the GroTop parser, I've not done this for any others. It also closes #305 by re-reducing triclinic box vectors prior to setting them via the OpenMM C++ API to avoid rounding issues due to loss of precision when reading from fixed-width format AMBER files. Finally, this closes #306 by using the alternative approach to fix the conda quotes issue from the
feature_cmap
branch.devel
into this branch before issuing this pull request (e.g. by runninggit pull origin devel
): [y]