Skip to content

Csghub enhance application space detail log handling #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2025

Conversation

youngbeom-shin
Copy link
Member

What this PR does:

  • Add timestamp extraction for logs
  • Implement ANSI to HTML conversion
  • Cache log blocks for efficient rendering
  • Improve log rendering with time blocks
    Which issue(s) this PR fixes:

Fixes # gitlab-883

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

Checklist:

  • I have added unit/e2e tests that prove your fix is effective or that this feature works.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have reviewed my own code and ensured that it follows the project's style guidelines.

Release note:


@youngbeom-shin youngbeom-shin self-assigned this Jun 23, 2025
@youngbeom-shin youngbeom-shin added GitLab linked linked to a GitLab task or issue. local-verified labels Jun 23, 2025
@youngbeom-shin youngbeom-shin marked this pull request as ready for review June 26, 2025 08:20
Copy link
Collaborator

@zhendi zhendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhendi zhendi merged commit ba22a42 into main Jun 26, 2025
3 checks passed
@zhendi zhendi deleted the csghub__enhance-application-space-detail-log-handling branch June 26, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitLab linked linked to a GitLab task or issue. local-verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants