Skip to content

Add registration bypass field #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablothedude merged 1 commit into from
May 15, 2025
Merged

Add registration bypass field #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,14 @@
# Changelog

## 5.3.0
- Add SSO registration bypass field to the institution configuration
-
## 5.2.0
- Add missing self vetting token endpoint

## 5.1.0
- Add SF6 and PHP8 support

## 4.1.7
- Add SSO on 2FA field to the institution configuration

Expand Down
5 changes: 5 additions & 0 deletions ci/qa/phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,11 @@ parameters:
count: 1
path: ../../src/Surfnet/StepupMiddlewareClientBundle/Configuration/Dto/InstitutionConfigurationOptions.php

-
message: "#^Property Surfnet\\\\StepupMiddlewareClientBundle\\\\Configuration\\\\Dto\\\\InstitutionConfigurationOptions\\:\\:\\$ssoRegistrationBypass has no type specified\\.$#"
count: 1
path: ../../src/Surfnet/StepupMiddlewareClientBundle/Configuration/Dto/InstitutionConfigurationOptions.php

-
message: "#^Property Surfnet\\\\StepupMiddlewareClientBundle\\\\Configuration\\\\Dto\\\\InstitutionConfigurationOptions\\:\\:\\$useRa has no type specified\\.$#"
count: 1
Expand Down
6 changes: 6 additions & 0 deletions ...urfnet/StepupMiddlewareClientBundle/Configuration/Dto/InstitutionConfigurationOptions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ class InstitutionConfigurationOptions implements Dto
*/
public $ssoOn2fa;

/**
* @Assert\Type(type="boolean", message="middleware_client.dto.configuration.sso_registration_bypass.must_be_boolean")
*/
public $ssoRegistrationBypass;

/**
* @Assert\Type(type="boolean", message="middleware_client.dto.configuration.allow_self_asserted_tokens.must_be_boolean")
*/
Expand Down Expand Up @@ -82,6 +87,7 @@ public static function fromData(array $data): self
$institutionConfigurationOptions->showRaaContactInformation = $data['show_raa_contact_information'];
$institutionConfigurationOptions->verifyEmail = $data['verify_email'];
$institutionConfigurationOptions->ssoOn2fa = $data['sso_on_2fa'];
$institutionConfigurationOptions->ssoRegistrationBypass = $data['sso_registration_bypass'];
$institutionConfigurationOptions->selfVet = $data['self_vet'];
$institutionConfigurationOptions->allowSelfAssertedTokens = $data['allow_self_asserted_tokens'];
$institutionConfigurationOptions->allowedSecondFactors = $data['allowed_second_factors'];
Expand Down
5 changes: 5 additions & 0 deletions ...reClientBundle/Tests/Configuration/Service/InstitutionConfigurationOptionsServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ public function testQueriedInstitutionConfigurationOptionsAreConvertedToADtoCorr
'verify_email' => true,
'self_vet' => true,
'sso_on_2fa' => false,
'sso_registration_bypass' => false,
'allow_self_asserted_tokens' => false,
'number_of_tokens_per_identity' => 2,
'allowed_second_factors' => ['sms', 'yubikey'],
Expand Down Expand Up @@ -105,6 +106,7 @@ public function testInstitutionConfigurationOptionsWithANonBooleanUseRaLocations
'verify_email' => true,
'self_vet' => false,
'sso_on_2fa' => false,
'sso_registration_bypass' => false,
'allow_self_asserted_tokens' => false,
'number_of_tokens_per_identity' => 1,
'allowed_second_factors' => ['sms', 'yubikey'],
Expand Down Expand Up @@ -156,6 +158,7 @@ public function testInstitutionConfigurationOptionsWithANonBooleanShowRaaContact
'self_vet' => false,
'allow_self_asserted_tokens' => false,
'sso_on_2fa' => false,
'sso_registration_bypass' => false,
'number_of_tokens_per_identity' => 0,
'allowed_second_factors' => ['sms', 'yubikey'],
'use_ra' => [$institution],
Expand Down Expand Up @@ -205,6 +208,7 @@ public function testInstitutionConfigurationOptionsWithANonArrayAllowedSecondFac
'verify_email' => true,
'self_vet' => false,
'sso_on_2fa' => false,
'sso_registration_bypass' => false,
'allow_self_asserted_tokens' => false,
'number_of_tokens_per_identity' => 5,
'allowed_second_factors' => ['sms', 'yubikey'],
Expand Down Expand Up @@ -255,6 +259,7 @@ public function testInstitutionConfigurationOptionsWithANonStringsAllowedSecondF
'verify_email' => true,
'self_vet' => false,
'sso_on_2fa' => false,
'sso_registration_bypass' => false,
'allow_self_asserted_tokens' => false,
'number_of_tokens_per_identity' => 1,
'allowed_second_factors' => ['sms', 'yubikey'],
Expand Down
Loading