Accept current Coven daemon health shape - #4512
Draft
pasmud wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Merge_Conflict - Pasi <pa.sen@outlook.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Cave’s daemon startup compatibility checks to accept the daemon’s current health document shape, preventing false “incompatible daemon” failures when the daemon reports the new named API version and/or a placeholder runtime version.
Changes:
- Extend accepted daemon API versions to include
coven.daemon.v1. - Treat
covenVersion: "0.0.0"as a placeholder and substitute the verified installed version for compatibility comparison. - Add regression tests covering both the new API version string and the placeholder runtime version case.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/daemon-startup-contract.ts | Expands supported API version allow-list and normalizes 0.0.0 runtime reporting to the installed version for compatibility checks. |
| src/lib/daemon-startup-contract.test.ts | Adds regression coverage for apiVersion: "coven.daemon.v1" and covenVersion: "0.0.0" acceptance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coven.daemon.v1, during Cave startup compatibility checks.covenVersion: "0.0.0"as a placeholder only after Cave has verified the installed Coven CLI version.Root Cause
Cave rejected a healthy local daemon because the daemon now reports API version
coven.daemon.v1, while Cave accepted only1andv1. The same Windows v0.2.5 health shape can reportcovenVersion: "0.0.0", which the status display already treats as a placeholder.Validation
node --experimental-strip-types src\lib\daemon-startup-contract.test.tsnode --experimental-strip-types src\lib\daemon-start.test.tspnpm test:daemon-faultspnpm check:tests-wiredpnpm typecheck