test: complete G2 evidence conformance - #6
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR completes remaining G2 contract conformance coverage by extending the scripted Coven test fixture with additional deterministic fault points and new assertions around stable adoption conflicts and structured denials.
Changes:
- Add adapter-neutral fault points for adoption policy denial and mid-inspection authority loss.
- Update the scripted G2 port to surface
PolicyDeniedduring adoption andUnavailableduring inspection under those injected faults. - Extend conformance assertions to verify durable state is unchanged across same-ID conflicts, policy denials, and authority-loss recovery.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/psyche-test-support/src/suites/coven.rs | Adds new fault-handling branches to the scripted port and expands the conformance suite with new conflict/denial/authority-loss assertions. |
| crates/psyche-test-support/src/coven.rs | Introduces two new adapter-neutral CovenFaultPoint variants used by fixtures and suites. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
316
to
324
| let selected_fault = { | ||
| let mut runtime = self.runtime()?; | ||
| runtime.adoption_calls = runtime.adoption_calls.saturating_add(1); | ||
| runtime.selected_fault | ||
| }; | ||
| if selected_fault == Some(CovenFaultPoint::AdoptionPolicyDenied) { | ||
| return Err(PortError::PolicyDenied); | ||
| } | ||
| let mut state = self.durable()?; |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the final reusable-suite requirements discovered during the G2 contract review.
The G2 evidence remains candidate until this exact source commit completes remote CI; the follow-up evidence commit will modify only
docs/G2-EVIDENCE.md.