Skip to content

test: verify bot review with /v1 endpoint#13

Closed
hqhq1025 wants to merge 2 commits into
mainfrom
test/bot-review-check-v2
Closed

test: verify bot review with /v1 endpoint#13
hqhq1025 wants to merge 2 commits into
mainfrom
test/bot-review-check-v2

Conversation

@hqhq1025

Copy link
Copy Markdown
Collaborator

Testing with /v1 path. Will close after verification.

@hqhq1025 hqhq1025 closed this Apr 18, 2026
@hqhq1025 hqhq1025 reopened this Apr 18, 2026
@hqhq1025 hqhq1025 closed this Apr 18, 2026
@hqhq1025 hqhq1025 reopened this Apr 18, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • [Minor] Remove the bot-review test marker from the published README — this adds transient verification noise to user-facing documentation without contributing project information, evidence README.md:27
    Suggested fix:
    Apache-2.0

Summary

Review mode: initial. One minor issue found in the latest diff: a test-only HTML comment was added to the rendered README.

Testing

Not run (automation); doc-only change.

open-codesign Bot

Comment thread README.md
## License

Apache-2.0
<!-- bot review test v2 1776500214 -->

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Minor] README.md:27 adds a test-only HTML comment to the published README. This looks like transient bot-verification noise rather than project documentation, so it should be removed before merge.

Suggested fix:

Apache-2.0

@Sun-sunshine06

Copy link
Copy Markdown
Collaborator

目前不建议合并,先处理下面这些问题:

  • CI 目前三平台 Lint, typecheck, test 都失败,失败点一致:apps/desktop/src/renderer/src/components/CanvasErrorBar.tsx 里访问了 CodesignState 上不存在的 iframeErrors / clearIframeErrors
  • DCO check 失败,提交里缺少 Signed-off-by:,需要按 DCO 要求补签名。
  • 当前 bot review 还指出 README.md:27 里加了测试用标记,这类验证性内容不应该进入面向用户的文档。

这个 PR 更像 bot-review 验证用分支。如果目标只是验证流程,建议在达到目的后直接关闭;如果还要保留,就至少先把上面三项处理干净。

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings

  • [Minor] Remove test-only README marker added in this commit — it introduces non-documentation noise in published project docs, evidence README.md:28
    Suggested fix:
    Apache-2.0
    <!-- bot review test v2 1776500214 -->

Summary

Review mode: follow-up after new commits. One minor issue found in the latest head diff: a new test-only HTML comment was added to README.md.

Testing

Not run (automation); doc-only change.

open-codesign Bot

Comment thread README.md

Apache-2.0
<!-- bot review test v2 1776500214 -->
<!-- test v3 1776517635 -->

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Minor] README.md:28 adds a test-only HTML comment to user-facing documentation. This is transient verification noise rather than project content, so it should be removed before merge.

Suggested fix:

Apache-2.0
<!-- bot review test v2 1776500214 -->

@hqhq1025 hqhq1025 closed this Apr 18, 2026
@hqhq1025 hqhq1025 deleted the test/bot-review-check-v2 branch April 18, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants