Add short titles for licenses #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarofgreen
reviewed
Feb 25, 2025
| def upgrade() -> None: | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.alter_column( | ||
| "dataset", "license_name", nullable=False, new_column_name="license_title" |
There was a problem hiding this comment.
I'm not sure why nullable=False is set here when the old definition was nullable=True?
There was a problem hiding this comment.
Oops, typo! Thanks for spotting, have fixed
jarofgreen
reviewed
Feb 25, 2025
| def downgrade() -> None: | ||
| # ### commands auto generated by Alembic - please adjust! ### | ||
| op.alter_column( | ||
| "dataset", "license_title", nullable=False, new_column_name="license_name" |
|
Rest looks great tho |
tillywoodfield
force-pushed
the
9-notifications
branch
from
5465d73 to
0d2e8c3
Compare
tillywoodfield
force-pushed
the
short-license-titles
branch
from
2e4c507 to
2953786
Compare
tillywoodfield
force-pushed
the
short-license-titles
branch
from
2953786 to
232298c
Compare
jarofgreen
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OpenDataServices/oc4ids-datastore-frontend#1