-
Notifications
You must be signed in to change notification settings - Fork 9
fallback link where no id guidance & country code abbreviations #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also, on my small laptop screen (1280px x 581px viewport), the footer hides the bottom of the homepage form (hides more of it with less height again) Changing the |
Refs #152. @BobHarper1: This looks similar to @timgdavies’ fix in #158. I get the impression from the discussion there that there are data issues preventing this from being merged :( |
@BobHarper1: See #133. Looks to me like @Bjwebb has fixed it on staging. (P.S. 👋 hi fellow Democracy Clubber! Small world! 😄 ) |
Whoops, great. |
That fix has also been on the live site for a while now, so I think @BobHarper1's bug still exist for even smaller screens. |
Oh, you’re quite right! But can I suggest moving further discussion about that to #133? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Caveat: Travelling without a dev environment accessible, so reviewing by reading the code, not spinning up test version).
These changes look good to me - and move us forward.
We know there are some underlying data issues still to address - but better to get these change in, and continue to work on the data.
This was merged accidentally, so I've undone with a reset. New pull request at #175 |
It took me a few visits to notice the link to publisher website at the top right of title.
For lists that don't have as much information, it might be better to provide the user a link to the website where they expect to find something e.g. under 'Find identifiers'. So if there is no guidance (
access.guidanceOnLocatingIds
) just present a link to theurl
(instead of 'None')