Skip to content

fallback link where no id guidance & country code abbreviations #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 27, 2017

Conversation

BobHarper1
Copy link
Contributor

It took me a few visits to notice the link to publisher website at the top right of title.

For lists that don't have as much information, it might be better to provide the user a link to the website where they expect to find something e.g. under 'Find identifiers'. So if there is no guidance (access.guidanceOnLocatingIds) just present a link to the url (instead of 'None')

image

@BobHarper1
Copy link
Contributor Author

Also, on my small laptop screen (1280px x 581px viewport), the footer hides the bottom of the homepage form (hides more of it with less height again)

image

Changing the @media rule to a wider width (100em) fixes this, for me, but I appreciate that might be a problem with other viewports.

@BobHarper1 BobHarper1 changed the title fallback link where no id guidance fallback link where no id guidance & country code abbreviations Aug 20, 2017
@BobHarper1 BobHarper1 closed this Aug 20, 2017
@BobHarper1 BobHarper1 reopened this Aug 20, 2017
@Bjwebb Bjwebb requested a review from timgdavies August 21, 2017 16:57
@andylolz
Copy link
Contributor

andylolz commented Aug 23, 2017

Refs #152.

@BobHarper1: This looks similar to @timgdavies’ fix in #158. I get the impression from the discussion there that there are data issues preventing this from being merged :(

@andylolz
Copy link
Contributor

andylolz commented Aug 23, 2017

Also, on my small laptop screen (1280px x 581px viewport), the footer hides the bottom of the homepage form (hides more of it with less height again)

@BobHarper1: See #133. Looks to me like @Bjwebb has fixed it on staging.

(P.S. 👋 hi fellow Democracy Clubber! Small world! 😄 )

@BobHarper1
Copy link
Contributor Author

Whoops, great.

@Bjwebb
Copy link
Member

Bjwebb commented Aug 24, 2017

@BobHarper1: See #133. Looks to me like @Bjwebb has fixed it on staging.

That fix has also been on the live site for a while now, so I think @BobHarper1's bug still exist for even smaller screens.

@andylolz
Copy link
Contributor

That fix has also been on the live site for a while now, so I think @BobHarper1's bug still exist for even smaller screens.

Oh, you’re quite right! But can I suggest moving further discussion about that to #133?

Copy link
Contributor

@timgdavies timgdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Caveat: Travelling without a dev environment accessible, so reviewing by reading the code, not spinning up test version).

These changes look good to me - and move us forward.

We know there are some underlying data issues still to address - but better to get these change in, and continue to work on the data.

@Bjwebb Bjwebb merged commit a2c04d2 into OpenDataServices:master Sep 27, 2017
@Bjwebb
Copy link
Member

Bjwebb commented Sep 27, 2017

This was merged accidentally, so I've undone with a reset.

New pull request at #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants