Update SEC_BOOT_CFG5 register size to 32 bits#25
Closed
ayodejiige wants to merge 1 commit intoOpenDevicePartnership:mainfrom
Closed
Update SEC_BOOT_CFG5 register size to 32 bits#25ayodejiige wants to merge 1 commit intoOpenDevicePartnership:mainfrom
ayodejiige wants to merge 1 commit intoOpenDevicePartnership:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SEC_BOOT_CFG5 register definition to use 32 bits instead of 16 bits, aligning the implementation with the correct hardware specification.
- Updated register size from 16 bits to 32 bits in both JSON configuration and generated Rust code
- Modified internal storage from 2-byte to 4-byte array to accommodate the larger size
- Updated all related type conversions and constants to maintain consistency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libs/imxrt-rom/src/registers/device.rs | Updated Rust struct implementation to use 4-byte array and 32-bit size constant |
| libs/imxrt-rom/registers.json | Changed register size specification from 16 to 32 bits |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Contributor
|
The problem is that for writing the register I have used ec-slimloader/libs/imxrt-rom/src/registers.rs Lines 114 to 119 in 76d6f5c |
Contributor
|
Fixed in #26. You can close this PR. |
JamesHuard
pushed a commit
that referenced
this pull request
Oct 7, 2025
We have a single device-driver definition of the OTP fuse registers, but can access them both from shadow registers, as well as from the OTP ROM API. In the OTP ROM API implementation writing to registers smaller than 32 bits did not do anything. See #25. This is due to calling `chunks_exact` with a size of 4, which does not yield any chunk if the remaining buffer cannot fit exactly that chunk: https://github.com/OpenDevicePartnership/ec-slimloader/blob/76d6f5cc2a422e0aa0a1fcf23a5c81c251276f5a/libs/imxrt-rom/src/registers.rs#L114-L119 This PR streamlines how the OTP words are accessed between OTP ROM API and shadow registers, and adds a few tests to validate that it does so correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.