Update dependencies to address Dependabot CVE reports#35
Merged
jerrysxie merged 5 commits intoOpenDevicePartnership:mainfrom Apr 3, 2026
Merged
Conversation
- Update rsa from 0.9.8 to 0.9.10 (RUSTSEC-2023-0071 / CVE-2023-49092) - Update time from 0.3.44 to 0.3.47 (RUSTSEC-2026-0009 / CVE-2026-25727) - Update probe-rs from 0.29.1 to 0.31.0 - Update object from 0.37.3 to 0.38 The probe-rs and object updates were needed because xmas-elf (a transitive dependency via espflash 3.x) could not be updated to 0.10 under probe-rs 0.29.1. probe-rs 0.31.0 uses espflash 4.x which dropped xmas-elf entirely, removing it from the dependency tree.
jerrysxie
requested review from
RobertZ2011,
felipebalbi,
tullom and
williampMSFT
There was a problem hiding this comment.
Pull request overview
Updates bootloader-tool’s Rust dependency set to address Dependabot-reported CVEs and remove a flagged transitive dependency (xmas-elf) by moving to newer probe-rs/espflash versions.
Changes:
- Bump direct dependencies:
probe-rsto0.31.0,objectto0.38, andrsato0.9.10. - Refresh
Cargo.lockto pull in patchedtime(0.3.47) and updated transitive dependencies, includingespflash4.3.0. - Remove
xmas-elffrom the resolved dependency tree via the updatedespflashdependency graph.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| bootloader-tool/Cargo.toml | Updates direct dependency versions to newer, security-aligned releases. |
| bootloader-tool/Cargo.lock | Locks updated transitive dependency graph (notably time patch and xmas-elf removal). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RobertZ2011
previously approved these changes
Mar 31, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kurtjd
previously approved these changes
Apr 1, 2026
- Change `to_rkth` return type from `Rkth` to `Result<Rkth, BootError>` - Replace `.unwrap()` on hash with `.map_err(|_| BootError::Hash)?` - Add `BootError::Hash` variant for hashing failures - Propagate the error with `?` at the call site in `check_image` - Fix typo: "lenght" -> "length"
kurtjd
approved these changes
Apr 1, 2026
williampMSFT
approved these changes
Apr 1, 2026
Contributor
Author
|
@gjpmsft @JamesHuard Please give this a review and let me know if there is any concern. |
JamesHuard
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
bootloader-tooldependencies to address CVE reports flagged by Dependabot.Dependency Changes
rsatimeprobe-rsobjectespflashxmas-elfDependabot Alerts & CVE Details
1.
time— CVE-2026-25727 / RUSTSEC-2026-0009: Denial of Service via Stack Exhaustion>=0.3.6, <0.3.47>=0.3.47timefrom 0.3.44 → 0.3.47, which adds a recursion depth limit.2.
rsa— CVE-2023-49092 / RUSTSEC-2023-0071: Marvin Attack (timing sidechannel)<=0.9.6rsacrate has no fully patched version yet — this advisory remains open. The update from 0.9.8 → 0.9.10 picks up the latest available improvements. This is a CLI tool, not a network service, so exposure is minimal.3.
xmas-elf— Dependabot flagged for update to 0.10xmas-elf0.9.1 was a transitive dependency viaespflash3.x (pulled in byprobe-rs0.29.1).probe-rsfrom 0.29.1 → 0.31.0, which depends onespflash^4.espflash4.x droppedxmas-elfentirely (replaced by theobjectcrate), removing it from the dependency tree altogether.Testing
cargo checkpasses successfully with all updated dependencies.