Remove per commit check#24
Merged
jerrysxie merged 1 commit intoOpenDevicePartnership:mainfrom Jul 1, 2025
Merged
Conversation
570a3c7 to
14f27cb
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the CI workflow by removing the per-commit matrix and the commit_list job, and updates job names accordingly.
- Removed the
commit_listjob and allneeds: commit_listdependencies - Dropped
strategy.matrix.commitandref: ${{ matrix.commit }}from checkout steps - Updated job names to no longer include
${{ matrix.commit }}
Comments suppressed due to low confidence (2)
.github/workflows/check.yml:1
- The top-level comment only lists fmt, clippy, and doc checks; consider updating it to include all current jobs (e.g., stable/features, deny, test, msrv) so the documentation matches the actual workflow.
# This workflow runs whenever a PR is opened or updated, or a commit is pushed to main. It runs
.github/workflows/check.yml:67
- [nitpick] Consider removing the fully commented-out semver job block if it's no longer needed; leftover commented code can clutter the workflow file and confuse future contributors.
# semver:
JamesHuard
approved these changes
Jun 26, 2025
asasine
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.