Skip to content

Remove per commit check#24

Merged
jerrysxie merged 1 commit intoOpenDevicePartnership:mainfrom
jerrysxie:remove-per-commit-check
Jul 1, 2025
Merged

Remove per commit check#24
jerrysxie merged 1 commit intoOpenDevicePartnership:mainfrom
jerrysxie:remove-per-commit-check

Conversation

@jerrysxie
Copy link
Copy Markdown
Contributor

No description provided.

@jerrysxie jerrysxie changed the title Remove per commit check Remove per commit check and update code owners Jun 26, 2025
@jerrysxie jerrysxie force-pushed the remove-per-commit-check branch from 570a3c7 to 14f27cb Compare June 26, 2025 15:29
@jerrysxie jerrysxie marked this pull request as ready for review June 26, 2025 15:29
Copilot AI review requested due to automatic review settings June 26, 2025 15:29
@jerrysxie jerrysxie requested a review from a team as a code owner June 26, 2025 15:29
@jerrysxie jerrysxie requested review from asasine, dymk, gjpmsft and kurtjd June 26, 2025 15:29
@jerrysxie jerrysxie changed the title Remove per commit check and update code owners Remove per commit check Jun 26, 2025
@jerrysxie jerrysxie enabled auto-merge (squash) June 26, 2025 15:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the CI workflow by removing the per-commit matrix and the commit_list job, and updates job names accordingly.

  • Removed the commit_list job and all needs: commit_list dependencies
  • Dropped strategy.matrix.commit and ref: ${{ matrix.commit }} from checkout steps
  • Updated job names to no longer include ${{ matrix.commit }}
Comments suppressed due to low confidence (2)

.github/workflows/check.yml:1

  • The top-level comment only lists fmt, clippy, and doc checks; consider updating it to include all current jobs (e.g., stable/features, deny, test, msrv) so the documentation matches the actual workflow.
# This workflow runs whenever a PR is opened or updated, or a commit is pushed to main. It runs

.github/workflows/check.yml:67

  • [nitpick] Consider removing the fully commented-out semver job block if it's no longer needed; leftover commented code can clutter the workflow file and confuse future contributors.
  # semver:

@jerrysxie jerrysxie merged commit ffb9041 into OpenDevicePartnership:main Jul 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants