patina_smbios: Add SMBIOS types#1383
patina_smbios: Add SMBIOS types#1383ansleythompson wants to merge 1 commit intoOpenDevicePartnership:mainfrom
Conversation
Define types for SMBIOS records according the SMBIOS specs 3.0+ and update records to use types. These structs/enums/bitfields force typing when creating SMBIOS records
⌛ QEMU Validation PendingQEMU validation is pending on successful CI completion.
This comment was automatically generated by the Patina QEMU PR Validation workflow. |
github-actions
bot
added
the
impact:non-functional
| /// Boot Up State | ||
| /// | ||
| #[derive(Copy, Clone, Debug)] | ||
| pub enum BootUpState { |
There was a problem hiding this comment.
These values are Chassis Types (SMBIOS spec Table 17 — System Enclosure or Chassis Types), not boot-up states. Boot-up states should be
Other = 0x01,
Unknown,
Safe,
Warning,
Critical,
...
| /// Power Supply State | ||
| /// | ||
| #[derive(Copy, Clone, Debug)] | ||
| pub enum PowerSupplyState { |
There was a problem hiding this comment.
I think these values look like ProcessorType values instead of PowerSupplyState Values
| matches!( | ||
| segment.ident.to_string().as_str(), | ||
| "u8" | "u16" | "u32" | "u64" | "i8" | "i16" | "i32" | "i64" | ||
| | "BiosCharacteristics" |
There was a problem hiding this comment.
I think we could use zerocopy::IntoBytes here instead. So we could have something like:
#[bitfield(u8)]
#[derive(zerocopy::IntoBytes)]
pub struct BiosCharacteristicsExt1 {
pub acpi_supported: bool,
pub usb_legacy_supported: bool,
// ...
I can refactor the smbios_record_macro to use zerocopy::IntoBytes::as_bytes() instead of the type name string list in a separate PR though. Will update you here when that's created
| spin = { workspace = true } | ||
| zerocopy = { workspace = true } | ||
| zerocopy-derive = { workspace = true } | ||
| bitfield = "0.17.0" |
There was a problem hiding this comment.
Can you use bitfield-struct from the workspace? If not, can you add it to the workspace and then use bitfield = { workspace = true } here?
2 participants
Description
Define types for SMBIOS records according the SMBIOS specs 3.0+ and update records to use types. These structs/enums/bitfields force typing when creating SMBIOS records
How This Was Tested
Integrated into patina-dxe-core-qemu with a local patch and verified with patina-qemu smbiosview
Integration Instructions
Use Smbios Types in place of magic numbers to create SMBIOS records.