Skip to content

[patina_mm] refactor current folder structure to allow external consumption#1413

Merged
kuqin12 merged 51 commits intoOpenDevicePartnership:mainfrom
kuqin12:bu2
Apr 1, 2026
Merged

[patina_mm] refactor current folder structure to allow external consumption#1413
kuqin12 merged 51 commits intoOpenDevicePartnership:mainfrom
kuqin12:bu2

Conversation

@kuqin12
Copy link
Copy Markdown
Contributor

@kuqin12 kuqin12 commented Mar 17, 2026

Description

Current patina_mm carries some definitions that can be shared by external users (mm communication header, buffer status, etc).

This change moves those files to a sub-module that does not require alloc.

It also separates the supervisor related definitions into its own file.

Resolves #1437.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

This was tested with local builds and booted to UEFI shell.

Integration Instructions

N/A

@patina-automation
Copy link
Copy Markdown
Contributor

patina-automation bot commented Mar 17, 2026

✅ QEMU Validation Passed

All QEMU validation jobs completed successfully.

Note: Q35 is only built on Windows hosts (QEMU boot is disabled due to a QEMU vfat issue).

Workflow run: https://github.com/OpenDevicePartnership/patina/actions/runs/23832225716

Boot Time to EFI Shell

Platform Elapsed
Q35 (Linux Host) 28.6s
SBSA (Linux Host) 1m 1s

Dependencies

Repository Ref
patina fdb0a69
patina-dxe-core-qemu 3eb6066
patina-fw-patcher 29264b2
patina-qemu firmware v3.0.0
patina-qemu build script da8fc60

This comment was automatically generated by the Patina QEMU PR Validation Post workflow.

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Mar 17, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../management_mode/protocol/mm_supervisor_request.rs 80.77% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@makubacki
Copy link
Copy Markdown
Collaborator

The validation failed due to --toolchain GCC5 in unrecognized :)

For the record, the workflow also needed to not pass --toolchain after the CLANGPDB transition in patina-qemu removed the parameter.

makubacki pushed a commit to OpenDevicePartnership/patina-devops that referenced this pull request Mar 27, 2026
After
OpenDevicePartnership/patina-qemu@f39bcdb,
the patina validation pipeline start to break due to unrecognized
toolchain:
OpenDevicePartnership/patina#1413

This change updated toolchain constants for Windows and Linux in the
QEMU CI workflow to only support CLANGPDB.
@kuqin12 kuqin12 requested a review from makubacki March 31, 2026 17:14
@kuqin12 kuqin12 requested a review from cfernald March 31, 2026 21:46
@kuqin12 kuqin12 enabled auto-merge (squash) April 1, 2026 04:26
@kuqin12 kuqin12 merged commit 83a8d8b into OpenDevicePartnership:main Apr 1, 2026
10 checks passed
@kuqin12 kuqin12 deleted the bu2 branch April 1, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:non-functional Does not have a functional impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: patina_mm uses alloc while hosting a few standard definitions

4 participants