[feature/patina-boot] patina_boot: Add ConnectController service trait#1459
Draft
kat-perez wants to merge 1 commit intoOpenDevicePartnership:feature/patina-bootfrom
Draft
[feature/patina-boot] patina_boot: Add ConnectController service trait#1459kat-perez wants to merge 1 commit intoOpenDevicePartnership:feature/patina-bootfrom
kat-perez wants to merge 1 commit intoOpenDevicePartnership:feature/patina-bootfrom
Conversation
Contributor
⌛ QEMU Validation PendingQEMU validation is pending on successful CI completion.
This comment was automatically generated by the Patina QEMU PR Validation workflow. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
kat-perez
force-pushed
the
connect-controller-service
branch
from
0e70816 to
65814d8
Compare
kat-perez
changed the title
kat-perez
force-pushed
the
connect-controller-service
branch
from
65814d8 to
759af3b
Compare
Add a pluggable ConnectController trait for controller connection strategies during device enumeration. This replaces the hardcoded connect_all() call in SimpleBootManager with a configurable strategy. - Add ConnectController trait with single connect() method - Add ConnectAllStrategy as the default (preserves existing behavior) - Add SimpleBootManager::with_connect_strategy() constructor - Make interleave_connect_and_dispatch() public and generic over the connection strategy so custom BootOrchestrators can reuse it SimpleBootManager::new() continues to use ConnectAllStrategy, so existing platforms are unaffected. Platforms needing selective enumeration (e.g., PCI-only, skip USB) implement ConnectController and pass it via with_connect_strategy().
kat-perez
force-pushed
the
connect-controller-service
branch
from
759af3b to
9bdd441
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a pluggable
ConnectControllertrait for controller connection strategies during device enumeration, replacing the hardcodedconnect_all()call inSimpleBootManager.ConnectControllertrait with singleconnect()methodConnectAllStrategydefault implementation (preserves existing behavior)SimpleBootManager::with_connect_strategy()constructor for custom strategiesinterleave_connect_and_dispatch()made generic over the connection functionThis enables platforms to implement selective device enumeration (e.g., PCI-only, skip USB for headless) without writing a full custom
BootOrchestrator.SimpleBootManager::new()behavior is unchanged — zero breakage for existing platforms.Ref: OpenDevicePartnership/modern-payload#205
How This Was Tested
cargo fmt,cargo clippycleanIntegration Instructions
No changes required for existing platforms.
SimpleBootManager::new()defaults toConnectAllStrategy.Platforms wanting selective enumeration use the new constructor: