Skip to content

Fix compilation in Xcode 16.4 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
Merged

Fix compilation in Xcode 16.4 #31

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1da0bbb
Add OEHACOutputReportIDUSBSubcommandReply (same underlying value as O…
Jul 6, 2025
a594e08
Merge branch 'master' into fix-xcode-164-compile
Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions OpenEmuSystem/OESwitchProControllerHIDDeviceHandler.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ typedef NS_ENUM(uint8_t, OEHACOuputReportID) {
OEHACOutputReportIDNFCIRFirmwareUpdatePacket = 0x03,
OEHACOutputReportIDRumble = 0x10,
OEHACOutputReportIDNFCIR = 0x11,
OEHACOutputReportIDUSBSubcommand = 0x80
OEHACOutputReportIDUSBSubcommand = 0x80,
OEHACOutputReportIDUSBSubcommandReply = 0x81
};


Expand Down Expand Up @@ -736,10 +737,7 @@ - (NSData *)_sendUSBSubcommand:(OEHACUSBSubcommandID)cmdid
return NO;
}
const OEHACUSBAcknowledgmentOutputReport *response = respData.bytes;
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wenum-compare"
if (response->reportID != OEHACInputReportIDUSBSubcommandReply) {
#pragma clang diagostic pop
if (response->reportID != OEHACOutputReportIDUSBSubcommandReply) {
NSLog(@"[dev %p] Invalid ACK from controller (USB subcommand %02X)", self, cmdid);
return NO;
}
Expand Down