maps handling negative values better #1205
Labels
i-good-first-issue
This issue is probably a good starting point for people new to coding or the OED project.
p-low-priority
reserved
Expected to be assigned to developer by project so others should not work on without prior approval.
t-bug
The issue is related to an aspect of the software which is incorrect
Milestone
Describe the bug
Originally, OED did not have negative readings but it is now allowed. If you place a negative value on a map, you see no circle. If you place the cursor over the expected location you see the correct hover. This screenshot shows this:
The issue is likely that src/client/app/containers/MapChartContainer.ts finds the max size where it should probably use the max - min size or something like this.
Another option might be to use another visual for negative (lines through color circle or something else) so it is clear to the user that some values are negative. This would be combined with fixing the actual size.
If others have thoughts about the look then please state them. The ideas here would have larger negative values have smaller circles.
To Reproduce
Steps to reproduce the behavior (assuming you have the usual developer testData loaded):
reading,start time,end time
-10,2023-01-01 00:00:00,2024-01-01 00:00:00
and do a CSV Readings upload where you specify the meter (from step 1), header row and refresh the daily/hourly readings, along with the CSV created in this step.
3. Go to the map and graph this meter.
4. Place cursor over Library to see
Note the provided CSV reading value is a constant -10 across all of 2023. It could be modified to get other values. If you want to place a circle in another location, looking at the location/GPS value for the amp meters will help.
Expected behavior
The circle size should be visible and scale with usage.
Additional context
None
The text was updated successfully, but these errors were encountered: