-
Notifications
You must be signed in to change notification settings - Fork 503
New wavetank library for HIL simulations with AD+MD #3065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
andrew-platt
wants to merge
95
commits into
OpenFAST:dev
Choose a base branch
from
andrew-platt:wavetank3
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7a21c0b.
This reverts commit 76d7d57.
This reverts commit 3b9db94.
This reverts commit 6d34d28.
This reverts commit d6f6321.
This reverts commit 1d07a3f.
This reverts commit 895ec6f.
This reverts commit 77efd85.
This reverts commit 0a212c3.
This reverts commit 26143a6.
This reverts commit 4e0ace3.
…ction"" This reverts commit 794e94d.
This reverts commit b9b0d21.
This reverts commit 1005f47.
This reverts commit dd40353.
This reverts commit 93a33fd.
This reverts commit c0a607c.
This reverts commit 609acfa.
This reverts commit 4bc88df.
This reverts commit 70370c8.
This reverts commit 565837e.
This reverts commit c34b688.
This reverts commit 47200a4.
This reverts commit 11d9af7.
This reverts commit 6c9acd2.
This reverts commit 24ead49.
This reverts commit a89ef35.
This reverts commit f936833.
c-bind - changed CalcOutput to CalcStep with new interface -- comment out most of it - comment out all the unused data for point tracking (moving to mesh) python - revised call to CalcStep in c-bind - add DriverDbg class to write debug file from python side
- check for open files - check if u allocated in c-bind Question in MD_End about deallocating stuff in miscvars: not necessary as it is handled by the destroy routine
- add state info into StructTmp - add outputs for RotSpeed, Azimuth, BldPitch, NacYaw
WaveTimeShift can only be positive valued
…segfault ADI_C_End was seg faulting if ADI_Init never completed
Missed a few things in seastate in a prior commit, so WaveTimeShift was not getting set
Using Froude scaling routines to show larger displacements for testing
- meshes and mapping for blade roots - Some pointers to cleanup reading of create and update mesh routines - missing input angle conversions to rad
- fixed bug in ADI for writing vtk outputs - fixed bug in wavetank default outputs
Left notes about what is missing in that
a12a444 to
1832fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-binding library interfaces
Module: AeroDyn
Module: MoorDyn
Module: SeaState
SeaState module for wave data generation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT not ready for merging
Feature or improvement description
Related issue, if one exists
None
Impacted areas of the software
Updates to following modules and interfaces:
AeroDyn_Inflow_C_BindinglibraryMoorDyn_C_BindinglibrarySeaState_C_BindinglibrarypyOpenFASTchangesNWTC_LibraryCUto a different value for writing to file instead of output to screen (used with LabView)some other details to fill out here
Additional supporting information
Test results, if applicable
New test case
Complete before ready for review