Streaming bodies 3 #2754
Open
Streaming bodies 3 #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdavisk6
reviewed
Feb 9, 2025
Comment on lines
+16
to
+29
| /* | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
Might be a double license here.
There was a problem hiding this comment.
Sorry - I am not following - I think this is the license block in all of the Feign core source files?
kdavisk6
reviewed
Feb 9, 2025
| @@ -801,7 +824,7 @@ private RequestTemplate appendHeader(String name, Iterable<String> values, boole | |||
| this.headers.remove(name); | |||
| return this; | |||
| } | |||
| if (name.equals("Content-Type")) { | |||
| if (name.equalsIgnoreCase("Content-Type")) { // headers are case-insensitive | |||
There was a problem hiding this comment.
Generally better to swap this comparison
Suggested change
| if (name.equalsIgnoreCase("Content-Type")) { // headers are case-insensitive | |
| if (("Content-Type").equalsIgnoreCase(name)) { // headers are case-insensitive |
kdavisk6
reviewed
Feb 9, 2025
| @@ -208,24 +209,13 @@ public ProtocolVersion protocolVersion() { | |||
| * See <a href="https://datatracker.ietf.org/doc/html/rfc7231#section-3.1.1.1">rfc7231 - Media | |||
| * Type</a> | |||
| */ | |||
| // TODO: KD - RFC 7231 spec says default charset if not specified is ISO-8859-1 (at least for | |||
| // HTTP/1.1). Seems dangerous to assume UTF_8 here... | |||
There was a problem hiding this comment.
UTF-8 was used historically as a baseline. While the spec may indicate another, for consistency, we should try to keep UTF-8 as our default until a larger release to update it.
kdavisk6
reviewed
Feb 9, 2025
| import java.lang.reflect.Type; | ||
| import java.nio.file.Files; | ||
|
|
||
| public class InputStreamAndFileEncoder implements Encoder { |
kdavisk6
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving request and response handling to use streams instead of in-memory byte arrays. Streams are retriable (up to some amount of reading).
To demonstrate this streaming functionality, I have added decoders for handling typical stream-oriented body types (see /core/src/main/java/feign/stream/InputStreamAndReaderDecoder.java) - I suspect that eventually these encoders/decoders will be broken out of the core library.
Current state of the branch: Response streaming has been implemented.
Next: Add support for request streaming.