You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently in dhis2's upsert function, http.get() is directly called inside the function and we have to pass state to it directly. This is an anti-pattern behaviour that we need to fix.
The fix is to use something like utill.request to do the http stuff for us without the operation overhead. As we do in most adaptors.
Where this gets tricky is that we're using axios in this adaptor. Does it still make sense to have a util.request written in axios? If we're going to have to refactor axios code, are we better off just swapping axios out and doing this all at once?
I keep changing my mind on the axios stuff. I had talked myself out of it last week. This week I think we may have to take the hit.
Issue Description
Currently in
dhis2
'supsert
function,http.get()
is directly called inside the function and we have to pass state to it directly. This is an anti-pattern behaviour that we need to fix.This is the current implementation:
See comment for reference: #1046 (comments)
The text was updated successfully, but these errors were encountered: