-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dhis2: Remove discover and switch to async/await
#1077
Conversation
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
@@ -0,0 +1,11 @@ | |||
--- | |||
'@openfn/language-dhis2': major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hunterachieng not all of these changes are major
It's ok to create multiple changeset files. You can have a 100 changes, created indivdually, no problem at all.
I'll fix this in the final changelog for the adaptor so no action needed now. But in future, good practice is to create a changeset every time you finish a feature that will affect users.
Summary
This PR extends the work of #1059 (which was merged early)
Fixes #51 #1047 #975 #1049 #1036
Details
This PR focused on:
discover()
functionasync/await
axios
version to1.8.2
upsert()
multiple entinties errorget
withparseAs:base64
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.