Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhis2: Remove discover and switch to async/await #1077

Merged
merged 9 commits into from
Mar 20, 2025

Conversation

hunterachieng
Copy link
Contributor

@hunterachieng hunterachieng commented Mar 20, 2025

Summary

This PR extends the work of #1059 (which was merged early)

Fixes #51 #1047 #975 #1049 #1036

Details

This PR focused on:

  • Remove discover() function
  • Switch to async/await
  • Bump axios version to 1.8.2
  • Implement better upsert() multiple entinties error
  • Fixed get with parseAs:base64
  • Update state docs in jsDoc

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to
know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our
Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • If this PR includes breaking changes, do we need to update any jobs in
    production? Is it safe to release?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
@@ -0,0 +1,11 @@
---
'@openfn/language-dhis2': major
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hunterachieng not all of these changes are major

It's ok to create multiple changeset files. You can have a 100 changes, created indivdually, no problem at all.

I'll fix this in the final changelog for the adaptor so no action needed now. But in future, good practice is to create a changeset every time you finish a feature that will affect users.

@josephjclark josephjclark merged commit 30e837f into epic/release-dhis2 Mar 20, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from New Issues to Done in v2 Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants