dhis2 Consider removing "patch" and "discover" for new dhis2 version

[taylordowns2000]

See these pull requests: OpenFn/language-dhis2#53 and OpenFn/language-dhis2#54

It's possible that neither of these operations are required any longer, but we should probably not make drastic changes until we consider the new shape of the dhis2 (with magic functions for visual building) and take into account dhis2 api changes.

[aleksa-krolls]

great - one more estimate on this one too pls @hunterachieng

[josephjclark]

Let's keep patch - we'll dump it in the http namespace and it won't hurt anyone

Let's drop discover. And early, so that it doesn't confuse us with other work

[hunterachieng]

@josephjclark Since the merged PR had this fixed, should we close it?

[josephjclark]

Ach @hunterachieng, thank you for flagging.

I merged that PR too early so you haven't had a chance to resolve this comment, but please make sure you address it in your next PR (along with async await).

Even so, I almost missed this because:

• dhis2: remove axios and fix documentation #1059 does not mention in the title or description that discover is removed
• dhis2: remove axios and fix documentation #1059 does not link to this issue, so there's no tracking on github
• The changeset for dhis2: remove axios and fix documentation #1059 does not mentioned that discover has been removed

It's super important that when PRs are marked for review, the PR title and description are up to date and accurate, and all relevant issues area tagged in the PR.

Before you mark the PR ready for review, it's really important that you:

• open the PR description in one tab
• open the changed files in another tab
• arrange those tabs side by side
• scroll down the diff to remind yourself what you've done, and make sure that all significant changes are clearly flagged in the PR description.

I do this for every single PR I open. And yes I still make mistakes! But this is a really big omission from the PR description and we shouldn't really be in this position right now

[hunterachieng]

This is noted and I shall address all these in the next PR.

[josephjclark]

Fixed in #1077