Skip to content

Add documentation for Oauth credentials #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 5, 2024
Merged

Add documentation for Oauth credentials #464

merged 5 commits into from
Apr 5, 2024

Conversation

taylordowns2000
Copy link
Member

  • Adds generic docs for Oauth2 credentials (image 1)
  • Adds some specific recommendations for Salesforce (image 2)
image image

christad92
christad92 reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@christad92 christad92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommended a change to 2 subtitles. Otherwise, I am very good with this.

adaptors/salesforce.md
available on your Lightning instance, reach out to the superuser who deployed it
and ask them to configure a Salesforce Oauth2 client.

#### Oauth2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connecting via Oauth2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connecting via OAuth2

adaptors/salesforce.md
![Credentials Menu](/img/credentials.png)
![Salesforce Oauth2](/img/salesforce-oauth2.png)

#### Security Token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connecting via Security Token

aleksa-krolls
aleksa-krolls approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@aleksa-krolls aleksa-krolls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I added some content and made minor changes

@aleksa-krolls
Copy link
Member

@taylordowns2000 added some content and made minor edits. Good to go from my side

mtuchi
mtuchi reviewed Apr 5, 2024
View reviewed changes
Copy link
Contributor

@mtuchi mtuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good but every mention of Oauth should be OAuth
If it'sOauth2 then it should be OAuth2

mtuchi
mtuchi reviewed Apr 5, 2024
View reviewed changes
@aleksa-krolls aleksa-krolls merged commit 070132f into main Apr 5, 2024
1 check passed
@aleksa-krolls aleksa-krolls deleted the oauth-creds branch April 5, 2024 11:44
@aleksa-krolls
Copy link
Member

closes #389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christad92 christad92 christad92 left review comments

@mtuchi mtuchi mtuchi left review comments

@aleksa-krolls aleksa-krolls aleksa-krolls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Documentation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taylordowns2000 @aleksa-krolls @christad92 @mtuchi