Logger: ignore empty lines in JSON Mode #906
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
In the logger, when running in json mode (ie, emit JSON objects, not strings), ignore anything with an empty message.
Fixes #899
Implementation Details
This PR is a little misleading because really what it does is prevents the worker sending empty log lines to Lightning.
But the implementation can be handled very neatly by the low level logging component. It'll simply not emit any empty log lines.
This makes sense: json logging is designed for tools to consume logs. And those tools don't need formatting log lines. Usually in the runtime we print empty lines to make the CLI pretty.
Note that
console.log(undefined)
will still log.AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy