Rate Limiting for Webhooks #3152
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgraded `hammer_backend_mnesia` to version 0.7.0 and `hammer` to version 7.0. - Removed old Hammer configuration from `config/config.exs` and `config/test.exs`. - Introduced a new `Lightning.RateLimiters` module to handle rate limiting for failure alerts. - Updated `Lightning.FailureAlerter` to utilize the new rate limiting logic. - Adjusted tests to reflect changes in rate limiting behavior.
- Introduced a new Bash script `local_cluster` for managing local cluster instances. - The script supports starting multiple instances (1-4) and connecting to specific nodes. - Added functionality for an optional Caddy reverse proxy to manage traffic on port 4000. - Updated `bootstrap.ex` to include RTM port configuration and refactored HTTP configuration handling for production and non-production environments.
- Introduced a new function `max_dataclip_size_bytes` in the `Lightning.Config` module to retrieve the maximum dataclip size from application environment. - Updated `LightningWeb.PlugConfigs` to use the new configuration function instead of directly fetching from the environment. - Modified tests in `WebhooksControllerTest` to stub the `max_dataclip_size_bytes` function for better isolation and control during testing.
- Renamed `inspect` to `to_list` in `ReplicatedRateLimiter` for clarity. - Updated `init` function in `ReplicatedRateLimiter` to use a configuration function. - Removed the `Listener` module from `Lightning.RateLimiters` as it is no longer needed. - Adjusted tests to reflect the new `to_list` function and removed unnecessary logging setup.
4 out of 10 (40%) left to reach consistency:
DeltaCrdt.get(config.crdt_name, {"project2", "#{Node.self()}"}) #=> {4, 1746007259}
jyeshe
force-pushed
the
rate-limit-webhooks
branch
4 times, most recently
from
88fdb5b to
4ae3501
Compare
jyeshe
force-pushed
the
rate-limit-webhooks
branch
from
4ae3501 to
5ec9781
Compare
jyeshe
force-pushed
the
rate-limit-webhooks
branch
from
bbc4a85 to
6110b1a
Compare
jyeshe
force-pushed
the
rate-limit-webhooks
branch
4 times, most recently
from
c0c533f to
6212e39
Compare
jyeshe
force-pushed
the
rate-limit-webhooks
branch
from
6212e39 to
285840c
Compare
jyeshe
force-pushed
the
rate-limit-webhooks
branch
from
285840c to
2f58f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR [adds/changes/fixes]... (A description of your work goes here.)
Closes #__
Validation steps
Additional notes for the reviewer
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner,:admin,:editor,:viewer)