Skip to content

Bump multiple dependencies to latest versions #3410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

Bump multiple dependencies to latest versions #3410

merged 2 commits into from
Jul 15, 2025

Conversation

stuartc
Copy link
Member

@stuartc stuartc commented Jul 15, 2025

Description

  • bcrypt_elixir: 3.2.1 → 3.3.2
  • sobelow: 0.13.0 → 0.14.0
  • jsonpatch: 1.0.2 → 2.2.2
  • oban: 2.18.3 → 2.19.4
  • eqrcode: 0.1.10 → 0.2.1

Updated API calls for jsonpatch v2.x compatibility:

  • Removed Jsonpatch.Mapper.from_map/1 and to_map/1 calls
  • Updated workflow_params.ex and workflow_live_helpers.ex

Removed custom transact/2 function from Lightning.Repo:

  • Ecto 3.13.2 now provides built-in transact functionality
  • Eliminated function conflicts and duplication

Closes #3264
Closes #3263
Closes #3262
Closes #3159
Closes #3116

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

stuartc added 2 commits July 15, 2025 15:20
- bcrypt_elixir: 3.2.1 → 3.3.2
- sobelow: 0.13.0 → 0.14.0
- jsonpatch: 1.0.2 → 2.2.2
- oban: 2.18.3 → 2.19.4
- eqrcode: 0.1.10 → 0.2.1

Updated API calls for jsonpatch v2.x compatibility:
- Removed Jsonpatch.Mapper.from_map/1 and to_map/1 calls
- Updated workflow_params.ex and workflow_live_helpers.ex

Removed custom transact/2 function from Lightning.Repo:
- Ecto 3.13.2 now provides built-in transact functionality
- Eliminated function conflicts and duplication

Closes #3264
Closes #3263
Closes #3262
Closes #3159
Closes #3116
@github-project-automation github-project-automation bot moved this to New Issues in v2 Jul 15, 2025
@stuartc stuartc requested review from elias-ba and midigofrank July 15, 2025 13:26
@stuartc stuartc self-assigned this Jul 15, 2025
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.99%. Comparing base (97fca0c) to head (755af8d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3410      +/-   ##
==========================================
+ Coverage   89.98%   89.99%   +0.01%     
==========================================
  Files         369      368       -1     
  Lines       14414    14408       -6     
==========================================
- Hits        12970    12967       -3     
+ Misses       1444     1441       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@midigofrank midigofrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niice

Copy link
Contributor

@elias-ba elias-ba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 ✨

@@ -44,7 +44,7 @@ defmodule LightningWeb.WorkflowNewLive.WorkflowParams do
"""
def apply_patches(current_params, patches) do
Jsonpatch.apply_patch(
patches |> Enum.map(&Jsonpatch.Mapper.from_map/1),
patches,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely

@stuartc stuartc merged commit e473d11 into main Jul 15, 2025
8 checks passed
@stuartc stuartc deleted the bump_deps branch July 15, 2025 16:53
@github-project-automation github-project-automation bot moved this from New Issues to Done in v2 Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants