Skip to content

Adv/16 method reader #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: adv/docs
Choose a base branch
from
Open

Adv/16 method reader #1131

wants to merge 12 commits into from

Conversation

peter-lawrey
Copy link
Member

@peter-lawrey peter-lawrey commented Jun 2, 2025

method-dispatch” documentation overhaul

🔍 What changed?

Module Scope
AbstractGeneratedMethodReader • Re-document every public + protected member.
• Explain the double-buffer message-history design and predicate/scanning flow.
• Inline‐docs for SERVICE_NAME, TEMP_MESSAGE_HISTORY_BY_SERVICE_NAME, etc.
GenerateMethodBridge / Delegate • New class headers that spell out multi-handler fan-out vs hot-swappable delegate use-cases.
• Docs for constructor, field emission, and code-gen strategy.
GenerateMethodReader • 300 + lines of additional explanations: source generation phases, naming algorithm, multipleNonMarshallableParamTypes flag, switch-block generation, interceptor handling.
Runtime helpers (VanillaMethodReader, Builder, MethodDelegate, MethodFilterOnFirstArg) • Clarify debug toggle, close-semantics, context chaining, sentinel objects.
• Describe builder knobs & system properties (disableReaderProxyCodegen, wire.mr.debug).
Utilities (WireDumper, Wires) • Move @SuppressWarnings below Javadoc to keep IDE tooltips clean.
Small tidy-ups Typos, line-wraps, import order, @NotNull consistency.

No functional / byte-code changes – only comments and whitespace.

@peter-lawrey peter-lawrey requested a review from tgd June 3, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant