Skip to content

fix(apps): Add-by-link FAB no longer overlaps last list item#523

Merged
rainxchzed merged 2 commits into
mainfrom
fix/apps-fab-overlap
May 6, 2026
Merged

fix(apps): Add-by-link FAB no longer overlaps last list item#523
rainxchzed merged 2 commits into
mainfrom
fix/apps-fab-overlap

Conversation

@rainxchzed
Copy link
Copy Markdown
Member

@rainxchzed rainxchzed commented May 5, 2026

Summary

LazyColumn on the Apps screen had no bottom content padding, so the Add-by-link Extended FAB sat on top of the last app card. Added an 88dp bottom inset (FAB ≈ 56dp + scaffold inset + breathing room).

Test plan

  • Open Apps screen with enough installed apps to fill the viewport — scroll to bottom, the last card is no longer hidden under the FAB.
  • Apps screen with few apps — bottom padding is harmless (still scrollable).
  • What's-new sheet on next 1.8.1 install shows the fix bullet in device language.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where the "Add by link" button on the Apps screen was covering the last app in the list, ensuring all apps are fully visible and accessible.
    • Improved dark-mode icon/background contrast by removing the translucent "liquid glass" effect for clearer, higher-contrast UI.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: aeed234b-5110-466e-ae97-ee93f6708e9c

📥 Commits

Reviewing files that changed from the base of the PR and between 92dca91 and 3b9aac6.

📒 Files selected for processing (14)
  • core/presentation/src/commonMain/composeResources/files/whatsnew/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/ar/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/bn/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/es/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/fr/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/hi/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/it/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/ja/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/ko/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/pl/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/ru/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/tr/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/zh-CN/16.json
  • feature/apps/presentation/src/commonMain/kotlin/zed/rainxch/apps/presentation/AppsRoot.kt
✅ Files skipped from review due to trivial changes (13)
  • core/presentation/src/commonMain/composeResources/files/whatsnew/pl/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/ja/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/ar/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/ko/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/tr/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/hi/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/fr/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/ru/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/it/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/zh-CN/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/es/16.json
  • core/presentation/src/commonMain/composeResources/files/whatsnew/bn/16.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • feature/apps/presentation/src/commonMain/kotlin/zed/rainxch/apps/presentation/AppsRoot.kt

Walkthrough

Adds bottom padding to the Apps screen list so the "Add-by-link" FAB no longer obscures the last item, and updates the FIXED release-note bullets across multiple localized JSON files to document the fix. (50 words)

Changes

Apps Screen FAB Overlap Fix

Layer / File(s) Summary
Core UI Fix
feature/apps/presentation/src/commonMain/kotlin/zed/rainxch/apps/presentation/AppsRoot.kt
LazyColumn contentPadding changed from PaddingValues(horizontal = 0.dp, vertical = 8.dp) to PaddingValues(start = 0.dp, end = 0.dp, top = 8.dp, bottom = 88.dp). Inline comments explain bottom padding accounts for FAB height + scaffold insets so the final item isn't obscured.
Release Notes (i18n)
core/presentation/src/commonMain/composeResources/files/whatsnew/16.json, .../whatsnew/{ar,bn,es,fr,hi,it,ja,ko,pl,ru,tr,zh-CN}/16.json
Each language's FIXED bullets array was updated: the existing "liquid glass / icon visibility" bullet preserved/adjusted for punctuation where needed, and a new bullet added noting the Apps screen "Add-by-link" / "Add via link" button no longer covers the last app in the list.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 I nudged the list with gentle hop,

So no more app gets hide-and-stop.
A roomy bottom, tidy and bright,
Lets every icon bask in light.
Thirteen tongues now cheer — padding wins tonight!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly summarizes the main change: fixing the overlap between the Add-by-link FAB and the last list item on the Apps screen.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/apps-fab-overlap

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rainxchzed rainxchzed force-pushed the fix/apps-fab-overlap branch from 92dca91 to 3b9aac6 Compare May 5, 2026 18:00
@rainxchzed rainxchzed merged commit 868388c into main May 6, 2026
1 check passed
@rainxchzed rainxchzed deleted the fix/apps-fab-overlap branch May 6, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant