fixes autoupdate with the new versions of Github-Store#1
Conversation
- replaced "bin" for "shortcuts" since it's a GUI program - regex is not needed when program uses Github's release
Greptile SummaryThis PR updates the
Confidence Score: 3/5The autoupdate URL pattern and checkver changes are clean, but the shortcut path relies on an unverified assumption about the MSI's internal directory layout — if wrong, users will get a broken install with no Start Menu entry. The switch from ZIP to MSI is the key change: Scoop will extract the MSI with lessmsi and then resolve the shortcut at bucket/github-store.json — specifically the Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Scoop
participant GitHub as GitHub API
participant lessmsi
User->>Scoop: scoop install github-store
Scoop->>GitHub: GET releases/download/v1.8.2/GitHub-Store-1.8.2.msi
GitHub-->>Scoop: GitHub-Store-1.8.2.msi
Scoop->>lessmsi: extract GitHub-Store-1.8.2.msi
lessmsi-->>Scoop: extracted files (directory structure from MSI)
Scoop->>Scoop: create shortcut at GitHub-Store/GitHub-Store.exe
Scoop-->>User: install complete
Note over Scoop,lessmsi: Shortcut path must match MSI internal directory layout
User->>Scoop: scoop checkver github-store -u
Scoop->>GitHub: GET /repos/OpenHub-Store/GitHub-Store/releases/latest
GitHub-->>Scoop: "tag_name = v1.8.3 → version = 1.8.3"
Scoop->>GitHub: GET releases/download/v1.8.3/GitHub-Store-1.8.3.msi
GitHub-->>Scoop: file (hash computed)
Scoop->>Scoop: update manifest version + hash + URL
Reviews (1): Last reviewed commit: "github-store: Update to version 1.8.2" | Re-trigger Greptile |
| "shortcuts": [ | ||
| [ | ||
| "GitHub-Store/GitHub-Store.exe", | ||
| "GitHub Store" | ||
| ] | ||
| ], |
There was a problem hiding this comment.
Shortcut path may not match MSI extraction structure
When Scoop processes an .msi file without a dedicated installer block, it uses lessmsi to extract the archive, preserving the MSI's internal directory table. For typical MSI packages targeting Program Files, the extracted tree often lands under a SourceDir/ProgramFilesFolder/… prefix rather than a flat GitHub-Store/ directory. If GitHub-Store.exe is not at exactly <appdir>/GitHub-Store/GitHub-Store.exe after extraction, this shortcut will silently fail to register and the app will be unlaunchable from Start Menu after scoop install.
adapted to work with the latest release format