Skip to content

fixes autoupdate with the new versions of Github-Store#1

Open
NECOtype wants to merge 6 commits into
OpenHub-Store:masterfrom
NECOtype:master
Open

fixes autoupdate with the new versions of Github-Store#1
NECOtype wants to merge 6 commits into
OpenHub-Store:masterfrom
NECOtype:master

Conversation

@NECOtype
Copy link
Copy Markdown

@NECOtype NECOtype commented May 2, 2026

adapted to work with the latest release format

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 13, 2026

Greptile Summary

This PR updates the github-store Scoop manifest from v1.6.2 to v1.8.2, adapting to the upstream project's switch from a ZIP archive to an MSI installer and a v-prefixed release tag format.

  • Version bumped to 1.8.2; download URL now points to an .msi file with a v prefix on the tag (v$version) and the autoupdate block mirrors this pattern — the checkver is simplified to the github shorthand which reads the latest GitHub release tag.
  • extract_dir + bin are replaced by a shortcuts entry pointing to \"GitHub-Store/GitHub-Store.exe\", which means the app no longer lands on PATH (appropriate for a GUI tool) but requires that path to exist verbatim in the MSI's extracted directory tree.

Confidence Score: 3/5

The autoupdate URL pattern and checkver changes are clean, but the shortcut path relies on an unverified assumption about the MSI's internal directory layout — if wrong, users will get a broken install with no Start Menu entry.

The switch from ZIP to MSI is the key change: Scoop will extract the MSI with lessmsi and then resolve the shortcut at GitHub-Store/GitHub-Store.exe. Whether that path exists in the extracted tree depends entirely on the MSI's internal directory table, which cannot be confirmed from the manifest alone. Everything else — the v-prefixed autoupdate URL, the github checkver shorthand, and the hash — looks correct.

bucket/github-store.json — specifically the shortcuts path and whether it matches the MSI's extracted structure.

Important Files Changed

Filename Overview
bucket/github-store.json Updates manifest from v1.6.2 ZIP to v1.8.2 MSI; switches checkver to GitHub shorthand and replaces bin+extract_dir with a shortcuts entry whose path depends on unverified MSI internal structure.

Sequence Diagram

sequenceDiagram
    participant User
    participant Scoop
    participant GitHub as GitHub API
    participant lessmsi

    User->>Scoop: scoop install github-store
    Scoop->>GitHub: GET releases/download/v1.8.2/GitHub-Store-1.8.2.msi
    GitHub-->>Scoop: GitHub-Store-1.8.2.msi
    Scoop->>lessmsi: extract GitHub-Store-1.8.2.msi
    lessmsi-->>Scoop: extracted files (directory structure from MSI)
    Scoop->>Scoop: create shortcut at GitHub-Store/GitHub-Store.exe
    Scoop-->>User: install complete

    Note over Scoop,lessmsi: Shortcut path must match MSI internal directory layout

    User->>Scoop: scoop checkver github-store -u
    Scoop->>GitHub: GET /repos/OpenHub-Store/GitHub-Store/releases/latest
    GitHub-->>Scoop: "tag_name = v1.8.3 → version = 1.8.3"
    Scoop->>GitHub: GET releases/download/v1.8.3/GitHub-Store-1.8.3.msi
    GitHub-->>Scoop: file (hash computed)
    Scoop->>Scoop: update manifest version + hash + URL
Loading

Reviews (1): Last reviewed commit: "github-store: Update to version 1.8.2" | Re-trigger Greptile

Comment thread bucket/github-store.json
Comment on lines +15 to +20
"shortcuts": [
[
"GitHub-Store/GitHub-Store.exe",
"GitHub Store"
]
],
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Shortcut path may not match MSI extraction structure

When Scoop processes an .msi file without a dedicated installer block, it uses lessmsi to extract the archive, preserving the MSI's internal directory table. For typical MSI packages targeting Program Files, the extracted tree often lands under a SourceDir/ProgramFilesFolder/… prefix rather than a flat GitHub-Store/ directory. If GitHub-Store.exe is not at exactly <appdir>/GitHub-Store/GitHub-Store.exe after extraction, this shortcut will silently fail to register and the app will be unlaunchable from Start Menu after scoop install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant