Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve mode selection #51

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Conversation

henkwiedig
Copy link
Collaborator

  • prefer progressive in mode selection
  • default to display's preferred mode when no match is found

Fixes: #44

@henkwiedig
Copy link
Collaborator Author

Maybe fixes: #26 as well
@zhouruixi ?

@henkwiedig henkwiedig changed the title improove mode selection improve mode selection Feb 21, 2025
@zhouruixi
Copy link

zhouruixi commented Feb 22, 2025

Thanks, I will test and report.

@zhouruixi
Copy link

Maybe fixes: #26 as well
@zhouruixi ?

#26 is a suggest, I have implemented this function in the startup script of pp. What we need to discuss is whether it is necessary to integrate this function into pp_rk. What do you mean by fix?

@zhouruixi
Copy link

The 1920x1080 screen modes supported by the monitor (use drm_info):

When not using the --screen-mode parameter, screen mode is well:
[email protected] preferred driver phsync pvsync 16:9

Before this patch, using the --screen-mode 1920x1080@60 parameter, screen mode is badly (interlace):
[email protected] driver phsync pvsync interlace 16:9

After this patch, using the --screen-mode 1920x1080@60 parameter, screen mode is well:
[email protected] driver phsync pvsync 16:9

This patch fix #44. Thanks!

@JohnDGodwin JohnDGodwin merged commit d0377ac into OpenIPC:master Feb 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PP not choosing the best screen mode when specifying screen_mode
3 participants