Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused required parameters #4626

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove unused required parameters #4626

wants to merge 2 commits into from
+6 −12

Conversation

aamant
Copy link
Contributor

@aamant aamant commented Feb 11, 2025

This parameters are not used and crontab generate errors when call function used with php8.3

@github-actions github-actions bot added the Component: Sales Relates to Mage_Sales label Feb 11, 2025
@sreichel
Copy link
Contributor

Any steps to reproduce? What the error message?

@aamant
Copy link
Contributor Author

aamant commented Feb 13, 2025

these parameters are never used. This code is legacy

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Component: Sales Relates to Mage_Sales waiting for feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aamant @sreichel @colinmollenhour