Handle errors during FMI initialization #1110
Conversation
|
The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2016-10-07_08-16-20. |
|
The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2017-10-02_11-49-39. |
| MMC_CATCH_INTERNAL(mmc_jumper) | ||
| if (!fmi2callbacksOK) { | ||
| return NULL; | ||
| } |
There was a problem hiding this comment.
This looks a bit strange. The if condition will always fail since fmi2callbacksOK is set to 1 unless you are doing something in MMC_CATCH_INTERNAL which is of course not the case since fmi2callbacksOK is local.
There was a problem hiding this comment.
It's not weird. It's setjmp/longjmp. The assignment to fmi2callbacksOK doesn't occur if an error is triggered.
There was a problem hiding this comment.
OK, it's a bit wrong since it returns before restoring the jump buffer. But a bigger problem is that when OM imports the FMU, we use thread-local storage for the threadData and we need to have separate threadData for the importing model... This seems to be what causes the crashes. Maybe we need to make the simulation check for existing threadData and re-use that...
No description provided.