Skip to content

Conversation

@rruusu
Copy link

@rruusu rruusu commented Oct 21, 2025

This pull request solves multiple issues that I have worked on during the past year.

They are cherry picked from the branch "work", which includes changes originally made to the master branch in October 2024. I hadn't had the time earlier to rebase my code on the major refactoring done to SystemSC.cpp on 19.11.2024 (6d7a397).

Note: This request is based on the maintenance/v2.1 branch, on which I have been working on.

Related Issues

Other changes

Includes some minor changes to logging messages.

- Report tolerance target at start of solution
- Show more decimals than one
- Use a one-based count for the loops
- Do not report KINSol success as a failure
- Report the actual tolerance used
- Report achieved tolerance with DumpAlgLoops
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2025

CLA assistant check
All committers have signed the CLA.

@arun3688
Copy link
Contributor

arun3688 commented Oct 21, 2025

@rruusu can you sign the contributor license agreement and also update the baseline for this test https://test.openmodelica.org/jenkins/blue/organizations/jenkins/OMSimulator/detail/PR-1519/1/tests, in the testsuite there is a file named rtest and you have to call

>> rtest -b equationpair.py

@arun3688
Copy link
Contributor

@rruusu please sign the contributor license agreement

@rruusu
Copy link
Author

rruusu commented Oct 21, 2025

@rruusu please sign the contributor license agreement

It seems that I had to sign with both my personal and work account, as the commits are associated with the email address used on the work account. (@reino-ruusu-semantum)

I hope that the license agreement is now ok.

I will look at the test failure tomorrow.

@rruusu
Copy link
Author

rruusu commented Oct 23, 2025

I had some trouble a year ago in running the test suite on Windows (see #1527), and I just gave up on it, due to lack of time, and then kind of forgot the existence of the whole test suite.

I finally got the test suite to work and the baseline is now updated.

@arun3688
Copy link
Contributor

@rruusu the license/cla is stuck can you copy and paste the following url in your browser https://cla-assistant.io/OpenModelica/OMSimulator?pullRequest=1519, you can sign the agreement and we can merge this

@reino-ruusu-semantum
Copy link

@rruusu the license/cla is stuck can you copy and paste the following url in your browser https://cla-assistant.io/OpenModelica/OMSimulator?pullRequest=1519, you can sign the agreement and we can merge this

It just says that I've already signed, for both accounts, and the robot changed its automatic comment above to "All committers have signed the CLA."

Is there anything else I can do?

@arun3688
Copy link
Contributor

@rruusu can you do a empty push the branch, so that it triggers the cla again.

>> git commit --allow-empty -m "trigger build"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants